Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button in about is defunct #11

Closed
stefanct opened this issue Jun 26, 2019 · 6 comments
Closed

Close button in about is defunct #11

stefanct opened this issue Jun 26, 2019 · 6 comments
Assignees

Comments

@stefanct
Copy link

Closing die dialog via escape key and window title (X) works fine.

@innir
Copy link
Owner

innir commented Jun 26, 2019

There is no close button in the about dialog:
grafik

What am I missing here?

@stefanct
Copy link
Author

Funny. This must be one of these cool Gnome features that eases the life of everybody... ;)

This is Debian's version (0.7.1-2 from stretch/stable) on Mate:
image
I haven't tried compiling it from source but I would not expect any change.

@innir
Copy link
Owner

innir commented Jun 26, 2019

Well, looking at the code (https://github.com/innir/gtranscribe/blob/master/bin/gtranscribe#L182-L194)
there is nothing about a close button. I just can't make something work that doesn't exist in the code.

Also, the documentation does not reference any close function: https://developer.gnome.org/gtk3/stable/GtkAboutDialog.html

I think it's actually Mate that's doing something strange here, not Gnome.

@innir
Copy link
Owner

innir commented Jun 26, 2019

Could you edit /usr/bin/gtranscribe and add

about_dialog.set_default_response(Gtk.ResponseType.CLOSE)
Before line 194 (https://github.com/innir/gtranscribe/blob/master/bin/gtranscribe#L194) maybe that helps.

@stefanct
Copy link
Author

Nope, but the solution from here works:

    about_dialog.run()
    about_dialog.hide()

instead of

    about_dialog.show()

The documentation does mention a close button btw (and the run() function) but does a poor job explaining the behavior. I now feel a bit sorry that I brought up such a stupid thing... but OTOH we came up with a solution(?) eventually, cheers :)

@innir innir closed this as completed in c29dd68 Jun 26, 2019
@innir
Copy link
Owner

innir commented Jun 26, 2019

No need to feel sorry - happy there was an easy solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants