Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: change the Change version code patch to a universal patch #2229

Closed
5 tasks done
federicogith opened this issue Jul 7, 2024 · 4 comments
Closed
5 tasks done
Labels
Suggestion Leave any other suggestions

Comments

@federicogith
Copy link

Application

YouTube

Suggestion description

That patch can be really useful because it allows to downgrade if an update is messed up

Acknowledgements

  • This issue is not a duplicate of an existing suggestion.
  • This is not a feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@federicogith federicogith added the Suggestion Leave any other suggestions label Jul 7, 2024
@inotia00
Copy link
Owner

inotia00 commented Jul 7, 2024

The Change version code patch is also implemented in the RVX patch, but is only targeted at Reddit.

The reasons for this are as follows:

  1. The Change version code patch does not work in the root environment.

Therefore, it cannot be used on YouTube and YouTube Music in the root environment.

  1. The Change version code patch is not needed for YouTube and YouTube Music in a non-root environment.
    (Because non-root apps are not shown in the update list of PlayStore)

For the Change version code patch to target YouTube or YouTube Music, more reasonable motivation is needed.

@KobeW50
Copy link
Contributor

KobeW50 commented Jul 7, 2024

For the Change version code patch to target YouTube or YouTube Music, more reasonable motivation is needed.

Users may want to downgrade YT/YTM if they discover an issue in a newer version.

But currently, the only thing that can be done is to export the settings config, uninstall YT/YTM RVX, and patch and install an older version where the issue doesn't exist.

It would be simpler if a user can just apply the Change version code patch and install the older version (without the issue) on top of the version that had the issue.

@inotia00
Copy link
Owner

inotia00 commented Jul 7, 2024

It would be simpler if a user can just apply the Change version code patch and install the older version (without the issue) on top of the version that had the issue.

makes sense

If the Change version code patch is implemented as a universal patch, issue #2211 will also likely be closed

@inotia00 inotia00 changed the title suggestion: add "Change version code" patch from ReVanced suggestion: change the Change version code patch to a universal patch Jul 7, 2024
@inotia00
Copy link
Owner

reflected in revanced-patches-4.10.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion Leave any other suggestions
Projects
None yet
Development

No branches or pull requests

3 participants