From 433458b6e30a402a87eb367c0904b8bee8b033d2 Mon Sep 17 00:00:00 2001 From: KobeW50 <84587632+KobeW50@users.noreply.github.com> Date: Mon, 27 May 2024 16:37:46 -0400 Subject: [PATCH 1/9] Clarify patch descriptions --- .../reddit/layout/screenshotpopup/ScreenshotPopupPatch.kt | 2 +- .../revanced/patches/youtube/layout/theme/MaterialYouPatch.kt | 2 +- .../patches/youtube/player/buttons/PlayerButtonsPatch.kt | 2 +- .../youtube/shorts/outlinebutton/ShortsOutlineButtonPatch.kt | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/kotlin/app/revanced/patches/reddit/layout/screenshotpopup/ScreenshotPopupPatch.kt b/src/main/kotlin/app/revanced/patches/reddit/layout/screenshotpopup/ScreenshotPopupPatch.kt index 858f347356..53acb5a543 100644 --- a/src/main/kotlin/app/revanced/patches/reddit/layout/screenshotpopup/ScreenshotPopupPatch.kt +++ b/src/main/kotlin/app/revanced/patches/reddit/layout/screenshotpopup/ScreenshotPopupPatch.kt @@ -16,7 +16,7 @@ import app.revanced.util.resultOrThrow @Suppress("unused") object ScreenshotPopupPatch : BaseBytecodePatch( name = "Disable screenshot popup", - description = "Adds an option to disable the popup that shows up when taking a screenshot.", + description = "Adds an option to disable the popup that appears when taking a screenshot.", dependencies = setOf( SettingsPatch::class, SharedResourceIdPatch::class diff --git a/src/main/kotlin/app/revanced/patches/youtube/layout/theme/MaterialYouPatch.kt b/src/main/kotlin/app/revanced/patches/youtube/layout/theme/MaterialYouPatch.kt index 2f121d7578..10dc49270b 100644 --- a/src/main/kotlin/app/revanced/patches/youtube/layout/theme/MaterialYouPatch.kt +++ b/src/main/kotlin/app/revanced/patches/youtube/layout/theme/MaterialYouPatch.kt @@ -13,7 +13,7 @@ import app.revanced.util.patch.BaseResourcePatch @Suppress("DEPRECATION", "unused") object MaterialYouPatch : BaseResourcePatch( name = "MaterialYou", - description = "Enables MaterialYou theme for Android 12+.", + description = "Applies the MaterialYou theme for Android 12+ devices.", dependencies = setOf( BaseThemePatch::class, SettingsPatch::class, diff --git a/src/main/kotlin/app/revanced/patches/youtube/player/buttons/PlayerButtonsPatch.kt b/src/main/kotlin/app/revanced/patches/youtube/player/buttons/PlayerButtonsPatch.kt index dd5a0b55df..d4932c7777 100644 --- a/src/main/kotlin/app/revanced/patches/youtube/player/buttons/PlayerButtonsPatch.kt +++ b/src/main/kotlin/app/revanced/patches/youtube/player/buttons/PlayerButtonsPatch.kt @@ -36,7 +36,7 @@ import com.android.tools.smali.dexlib2.iface.instruction.formats.Instruction3rc @Suppress("unused") object PlayerButtonsPatch : BaseBytecodePatch( name = "Hide player buttons", - description = "Adds an option to hide buttons in the video player.", + description = "Adds options to hide buttons in the video player.", dependencies = setOf( CastButtonPatch::class, FullscreenButtonViewStubPatch::class, diff --git a/src/main/kotlin/app/revanced/patches/youtube/shorts/outlinebutton/ShortsOutlineButtonPatch.kt b/src/main/kotlin/app/revanced/patches/youtube/shorts/outlinebutton/ShortsOutlineButtonPatch.kt index a7b2140f06..577df9febc 100644 --- a/src/main/kotlin/app/revanced/patches/youtube/shorts/outlinebutton/ShortsOutlineButtonPatch.kt +++ b/src/main/kotlin/app/revanced/patches/youtube/shorts/outlinebutton/ShortsOutlineButtonPatch.kt @@ -10,7 +10,7 @@ import app.revanced.util.patch.BaseResourcePatch @Suppress("unused") object ShortsOutlineButtonPatch : BaseResourcePatch( name = "Shorts outline button", - description = "Applies the outline icon to the action buttons in the Shorts player.", + description = "Applies, at compile time, the outline icon to the action buttons in the Shorts player.", dependencies = setOf(SettingsPatch::class), compatiblePackages = COMPATIBLE_PACKAGE ) { From e7b62c9900cd2a919a7b221a40e393fdb806706c Mon Sep 17 00:00:00 2001 From: KobeW50 <84587632+KobeW50@users.noreply.github.com> Date: Mon, 27 May 2024 16:39:03 -0400 Subject: [PATCH 2/9] (YouTube): Capitalize proper nouns in settings and other small string fixes --- .../youtube/settings/host/values/strings.xml | 90 +++++++++---------- 1 file changed, 45 insertions(+), 45 deletions(-) diff --git a/src/main/resources/youtube/settings/host/values/strings.xml b/src/main/resources/youtube/settings/host/values/strings.xml index 3bc7943137..fe155b8029 100644 --- a/src/main/resources/youtube/settings/host/values/strings.xml +++ b/src/main/resources/youtube/settings/host/values/strings.xml @@ -177,7 +177,7 @@ Store" Hide channel profile links Links at the top of channel profile is hidden. Links at the top of channel profile is shown. - "Hide 'For You' shelf" + "Hide 'For You' shelves" "'For You' shelves are hidden." "'For You' shelves are shown." @@ -250,9 +250,9 @@ Limitations: Hide videos based on duration Hide videos with shorter than or longer than duration.\n\nKnown issue: It will not hide videos in the player related videos, instead it will hide the timestamp. Longer than duration - Videos with duration longer than this number will be hidden. + Videos with durations longer than this number will be hidden. Shorter than duration - Videos with duration shorter than this number will be hidden. + Videos with durations shorter than this number will be hidden. View count filter @@ -378,26 +378,26 @@ Some components may not be hidden." Hide create button Create button is hidden. Create button is shown. - Hide home button + Hide Home button Home button is shown. Home button is hidden. - Hide library button + Hide Library button Library button is hidden. Library button is shown. Hide notifications button Notifications button is hidden. Notifications button is shown. - Hide shorts button + Hide Shorts button Shorts button is hidden. Shorts button is shown. - Hide subscriptions button + Hide Subscriptions button Subscriptions button is hidden. Subscriptions button is shown. - Hide navigation label - Navigation label is hidden. - Navigation label is shown. - Switch create with notifications - "Swaps the positions of the create button and notification button by spoofing device information. + Hide navigation labels + Navigation labels are hidden. + Navigation labels are shown. + Swap create and Notifications buttons + "Swaps the positions of the create button with the Notifications button by spoofing device information. • The device may need to be rebooted for a change of this setting to take effect. • Disabling this setting loads more ads from the server side. @@ -426,8 +426,8 @@ Captions" Wide search bar is enabled. Wide search bar is disabled. Enable wide search bar with header - Wide search bar includes YouTube header. - Wide search bar does not include YouTube header. + Wide search bar does not hide the YouTube header. + Wide search bar hides the YouTube header. Enable wide search bar in You tab "Enabling this setting will disable the settings button in the You tab. @@ -525,34 +525,34 @@ Autoplay can be changed in YouTube settings: Action buttons Hide or show action buttons under videos. - Hide clip button + Hide Clip button Clip button is hidden. Clip button is shown. - Hide download button + Hide Download button Download button is hidden. Download button is shown. Hide like and dislike buttons Like and dislike buttons are hidden. Like and dislike buttons are shown. - Hide remix button + Hide Remix button Remix button is hidden. Remix button is shown. - Hide report button + Hide Report button Report button is hidden. Report button is shown. - Hide rewards button + Hide Rewards button Rewards button is hidden. Rewards button is shown. - Hide save to playlist button - Save to playlist button is hidden. - Save to playlist button is shown. - Hide share button + "Hide 'Save to playlist' button" + "'Save to playlist' button is hidden." + "'Save to playlist' button is shown." + Hide Share button Share button is hidden. Share button is shown. - Hide shop button + Hide Shop button Shop button is hidden. Shop button is shown. - Hide thanks button + Hide Thanks button Thanks button is hidden. Thanks button is shown. @@ -572,12 +572,12 @@ Autoplay can be changed in YouTube settings: Channel bar Hide or show components of the channel bar under videos. - Hide join button + Hide Join button Join button is hidden. Join button is shown. - Hide start trial button - Start trial button is hidden. - Start trial button is shown. + "Hide 'Start trial' button" + "'Start trial' button is hidden." + "'Start trial' button is shown." Comments @@ -586,9 +586,9 @@ Autoplay can be changed in YouTube settings: Hide channel guidelines Channel guidelines are hidden. Channel guidelines are shown. - Hide comments by members banner - Comments by members banner is hidden. - Comments by members banner is shown. + "Hide 'Comments by members' banner" + "'Comments by members' banner is hidden." + "'Comments by members' banner is shown." Hide comments section Comments section is hidden. Comments section is shown. @@ -601,10 +601,10 @@ Autoplay can be changed in YouTube settings: Hide preview comment type This does not change the size of the comment section, so it is possible to open the live chat replay in the comment section. This changes the size of the comment section, so it is impossible to open a live chat replay in the comment section. - Hide create shorts button + Hide create Shorts button Create Shorts button is hidden. Create Shorts button is shown. - Hide thanks button + Hide Thanks button Thanks button is hidden. Thanks button is shown. Hide timestamp and emoji buttons @@ -922,14 +922,14 @@ Please download %2$s from the website." Video descriptions are not expanded automatically. Title in video description panel "Enter the title of the video description panel in your language. -'Expand video description' may not work if the entered string does not match the video description panel title. " +'Expand video description' may not work if the entered string does not match the video description panel title." Description Shorts - Change shorts repeat state + Change Shorts repeat state Autoplay Default Pause @@ -941,7 +941,7 @@ Please download %2$s from the website." Shorts shelves - Hide shorts shelves + Hide Shorts shelves "Hides Shorts shelves. Limitation: Official headers in search results will be hidden." @@ -962,10 +962,10 @@ Limitation: Official headers in search results will be hidden." Shorts player Hide or show components in the Shorts player. - Hide join button + Hide Join button Join button is hidden. Join button is shown. - Hide subscribe button + Hide Subscribe button Subscribe button is hidden. Subscribe button is shown. Hide paused overlay buttons @@ -974,7 +974,7 @@ Limitation: Official headers in search results will be hidden." Hide paid promotion label Paid promotion label is hidden. Paid promotion label is shown. - Hide shop button + Hide Shop button Shop button is hidden. Shop button is shown. Hide tagged products @@ -1007,19 +1007,19 @@ Limitation: Official headers in search results will be hidden." Action buttons - Hide like button + Hide Like button Like button is hidden. Like button is shown. - Hide dislike button + Hide Dislike button Dislike button is hidden. Dislike button is shown. Hide comments button Comments button is hidden. Comments button is shown. - Hide remix button + Hide Remix button Remix button is hidden. Remix button is shown. - Hide share button + Hide Share button Share button is hidden. Share button is shown. Hide sound button @@ -1033,7 +1033,7 @@ Limitation: Official headers in search results will be hidden." Hide navigation bar Navigation bar is hidden. Navigation bar is shown. - Return shorts channel name + Return Shorts channel name Channel name is used. Channel handle is used. From 9dfad691dfb8d0f2ee19b7099d7c9a96181ee976 Mon Sep 17 00:00:00 2001 From: KobeW50 <84587632+KobeW50@users.noreply.github.com> Date: Mon, 27 May 2024 17:27:56 -0400 Subject: [PATCH 3/9] (YouTube - Player flyout menu): Capitalize and quote strings --- .../youtube/settings/host/values/strings.xml | 82 +++++++++---------- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/src/main/resources/youtube/settings/host/values/strings.xml b/src/main/resources/youtube/settings/host/values/strings.xml index fe155b8029..5b16804088 100644 --- a/src/main/resources/youtube/settings/host/values/strings.xml +++ b/src/main/resources/youtube/settings/host/values/strings.xml @@ -618,60 +618,60 @@ Autoplay can be changed in YouTube settings: Change toggle type Text toggles are used. Switch toggles are used. - Hide audio track menu - Audio track menu is hidden. - Audio track menu is shown. - Hide captions menu + "Hide 'Audio track' menu" + "'Audio track' menu is hidden." + "'Audio track' menu is shown." + Hide Captions menu Captions menu is hidden. Captions menu is shown. Hide captions menu footer Captions menu footer is hidden. Captions menu footer is shown. - Hide lock screen menu - Lock screen menu is hidden. - Lock screen menu is shown. - Hide more information menu - More information menu is hidden. - More information menu is shown. - Hide playback speed menu - Playback speed menu is hidden. - Playback speed menu is shown. + "Hide 'Lock screen' menu" + "'Lock screen' menu is hidden." + "'Lock screen' menu is shown." + "Hide 'More information' menu" + "'More information' menu is hidden." + "'More information' menu is shown." + "Hide 'Playback speed' menu" + "'Playback speed' menu is hidden." + "'Playback speed' menu is shown." Hide quality menu footer Quality menu footer is hidden. Quality menu footer is shown. - Hide report menu + Hide Report menu Report menu is hidden. Report menu is shown. Additional settings - Hide ambient mode menu - Ambient mode menu is hidden. - Ambient mode menu is shown. - Hide help & feedback menu - Help & feedback menu is hidden. - Help & feedback menu is shown. - Hide listen with YouTube Music menu - Listen with YouTube Music menu is hidden. - Listen with YouTube Music menu is shown. - Hide loop video menu - Loop video menu is hidden. - Loop video menu is shown. - Hide picture-in-picture menu - Picture-in-picture menu is hidden. - Picture-in-picture menu is shown. - Hide premium controls menu - Premium controls menu is hidden. - Premium controls menu is shown. - Stable volume menu is shown. - Stable volume menu is hidden. - Hide stable volume menu - Hide stats for nerds menu - Stats for nerds menu is hidden. - Stats for nerds menu is shown. - Hide watch in VR menu - Watch in VR menu is hidden. - Watch in VR menu is shown. + "Hide 'Ambient mode' menu" + "'Ambient mode' menu is hidden." + "'Ambient mode' menu is shown." + "Hide 'Help & feedback' menu" + "'Help & feedback' menu is hidden." + "'Help & feedback' menu is shown." + "Hide 'Listen with YouTube Music' menu" + "'Listen with YouTube Music' menu is hidden." + "'Listen with YouTube Music' menu is shown." + "Hide 'Loop video' menu" + "'Loop video' menu is hidden." + "'Loop video' menu is shown." + "Hide 'Picture-in-picture' menu" + "'Picture-in-picture' menu is hidden." + "'Picture-in-picture' menu is shown." + "Hide 'Listening controls' menu" + "'Listening controls' menu is hidden." + "'Listening controls' menu is shown." + "Hide 'Stable volume' menu" + "'Stable volume' menu is shown." + "'Stable volume' menu is hidden." + "Hide 'Stats for nerds' menu" + "'Stats for nerds' menu is hidden." + "'Stats for nerds' menu is shown." + "Hide 'Watch in VR' menu" + "'Watch in VR' menu is hidden." + "'Watch in VR' menu is shown." Fullscreen From 740839338db10811fde332d07e388b17fec42d0c Mon Sep 17 00:00:00 2001 From: inotia00 <108592928+inotia00@users.noreply.github.com> Date: Tue, 28 May 2024 16:08:15 +0900 Subject: [PATCH 4/9] Update src/main/resources/youtube/settings/host/values/strings.xml Co-authored-by: KobeW50 <84587632+KobeW50@users.noreply.github.com> --- src/main/resources/youtube/settings/host/values/strings.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/resources/youtube/settings/host/values/strings.xml b/src/main/resources/youtube/settings/host/values/strings.xml index 5b16804088..31380244c7 100644 --- a/src/main/resources/youtube/settings/host/values/strings.xml +++ b/src/main/resources/youtube/settings/host/values/strings.xml @@ -543,9 +543,9 @@ Autoplay can be changed in YouTube settings: Hide Rewards button Rewards button is hidden. Rewards button is shown. - "Hide 'Save to playlist' button" - "'Save to playlist' button is hidden." - "'Save to playlist' button is shown." + Hide Save button + Save button is hidden. + Save button is shown. Hide Share button Share button is hidden. Share button is shown. From 198eabfa378e5ac636c01d6b3b531d6d3be4d158 Mon Sep 17 00:00:00 2001 From: KobeW50 <84587632+KobeW50@users.noreply.github.com> Date: Tue, 28 May 2024 03:39:10 -0400 Subject: [PATCH 5/9] (YouTube): update strings.xml --- .../youtube/settings/host/values/strings.xml | 212 +++++++++--------- 1 file changed, 106 insertions(+), 106 deletions(-) diff --git a/src/main/resources/youtube/settings/host/values/strings.xml b/src/main/resources/youtube/settings/host/values/strings.xml index 5b16804088..4f63a0c81d 100644 --- a/src/main/resources/youtube/settings/host/values/strings.xml +++ b/src/main/resources/youtube/settings/host/values/strings.xml @@ -129,7 +129,7 @@ Tap here to learn more about DeArrow." "Hide 'Notify me' button" "'Notify me' button is hidden." "'Notify me' button is shown." - Hide playables + Hide Playables Playables are hidden. Playables are shown. "Hide 'Show more' button" @@ -168,15 +168,15 @@ Tap here to learn more about DeArrow." "Shorts Playlists Store" - Hide browse store button - Browse store button is hidden. - Browse store button is shown. + Hide Visit store button + Visit store button is hidden. + Visit store button is shown. Hide channel member shelf Channel member shelf is hidden. Channel member shelf is shown. Hide channel profile links - Links at the top of channel profile is hidden. - Links at the top of channel profile is shown. + Links at the top of channel profiles are hidden. + Links at the top of channel profiles are shown. "Hide 'For You' shelves" "'For You' shelves are hidden." "'For You' shelves are shown." @@ -375,7 +375,7 @@ Some components may not be hidden." Enable narrow navigation buttons Spacing between navigation buttons is narrow. Spacing between navigation buttons is normal. - Hide create button + Hide Create button Create button is hidden. Create button is shown. Hide Home button @@ -396,8 +396,8 @@ Some components may not be hidden." Hide navigation labels Navigation labels are hidden. Navigation labels are shown. - Swap create and Notifications buttons - "Swaps the positions of the create button with the Notifications button by spoofing device information. + Swap Create and Notifications buttons + "Swaps the positions of the Create button with the Notifications button by spoofing device information. • The device may need to be rebooted for a change of this setting to take effect. • Disabling this setting loads more ads from the server side. @@ -408,7 +408,7 @@ Some components may not be hidden." Hide elements of the YouTube settings menu. Hide YouTube settings menu - Hide elements in YouTube settings menu. + Hide elements of the YouTube settings menu. YouTube settings menu filter List of YouTube settings menu names to filter, separated by new lines. "Account @@ -429,32 +429,32 @@ Captions" Wide search bar does not hide the YouTube header. Wide search bar hides the YouTube header. Enable wide search bar in You tab - "Enabling this setting will disable the settings button in the You tab. + "Enabling this setting will disable the Settings button in the You tab. In this case, please use the following path to access the settings: You tab → View channel → Menu → Settings." - Hide cast button + Hide Cast button Cast button is hidden. Cast button is shown. - Hide create button + Hide Create button Create button is hidden. Create button is shown. - Hide notification button - Notification button is hidden. - Notification button is shown. - Hide search term thumbnail + Hide Notifications button + Notifications button is hidden. + Notifications button is shown. + Hide search term thumbnails Thumbnails in the search term history are hidden. Thumbnails in the search term history are shown. Hide voice search button Voice search button is hidden. Voice search button is shown. - Replace create button - Replaces create button with settings button. + Replace Create button + Replaces the Create button with the Settings button. Action type to assign to button - "Tap to open RVX Settings. -Tap and hold to open YouTube Settings." - "Tap to open YouTube Settings. -Tap and hold to open RVX Settings." + "Tap to open RVX settings. +Tap and hold to open YouTube settings." + "Tap to open YouTube settings. +Tap and hold to open RVX settings." @@ -506,8 +506,8 @@ Note: Seek undo message is hidden. Seek undo message is shown. Hide suggested actions - Suggested actions hidden. - Suggested actions shown. + Suggested actions are hidden. + Suggested actions are shown. Hide timed reactions Timed reactions are hidden. Timed reactions are shown. @@ -531,9 +531,9 @@ Autoplay can be changed in YouTube settings: Hide Download button Download button is hidden. Download button is shown. - Hide like and dislike buttons - Like and dislike buttons are hidden. - Like and dislike buttons are shown. + Hide Like and Dislike buttons + Like and Dislike buttons are hidden. + Like and Dislike buttons are shown. Hide Remix button Remix button is hidden. Remix button is shown. @@ -543,9 +543,9 @@ Autoplay can be changed in YouTube settings: Hide Rewards button Rewards button is hidden. Rewards button is shown. - "Hide 'Save to playlist' button" - "'Save to playlist' button is hidden." - "'Save to playlist' button is shown." + Hide Save button + Save button is hidden. + Save button is shown. Hide Share button Share button is hidden. Share button is shown. @@ -575,9 +575,9 @@ Autoplay can be changed in YouTube settings: Hide Join button Join button is hidden. Join button is shown. - "Hide 'Start trial' button" - "'Start trial' button is hidden." - "'Start trial' button is shown." + Hide Start trial button + Start trial button is hidden. + Start trial button is shown. Comments @@ -599,8 +599,8 @@ Autoplay can be changed in YouTube settings: Preview comment is hidden. Preview comment is shown. Hide preview comment type - This does not change the size of the comment section, so it is possible to open the live chat replay in the comment section. - This changes the size of the comment section, so it is impossible to open a live chat replay in the comment section. + This does not change the size of the comments section, so it is possible to open the live chat replay in the comments section. + This changes the size of the comments section, so it is impossible to open a live chat replay in the comments section. Hide create Shorts button Create Shorts button is hidden. Create Shorts button is shown. @@ -618,24 +618,24 @@ Autoplay can be changed in YouTube settings: Change toggle type Text toggles are used. Switch toggles are used. - "Hide 'Audio track' menu" - "'Audio track' menu is hidden." - "'Audio track' menu is shown." + Hide Audio track menu + Audio track menu is hidden. + Audio track menu is shown. Hide Captions menu Captions menu is hidden. Captions menu is shown. Hide captions menu footer Captions menu footer is hidden. Captions menu footer is shown. - "Hide 'Lock screen' menu" - "'Lock screen' menu is hidden." - "'Lock screen' menu is shown." - "Hide 'More information' menu" - "'More information' menu is hidden." - "'More information' menu is shown." - "Hide 'Playback speed' menu" - "'Playback speed' menu is hidden." - "'Playback speed' menu is shown." + Hide Lock screen menu + Lock screen menu is hidden. + Lock screen menu is shown. + Hide More information menu + More information menu is hidden. + More information menu is shown. + Hide Playback speed menu + Playback speed menu is hidden. + Playback speed menu is shown. Hide quality menu footer Quality menu footer is hidden. Quality menu footer is shown. @@ -645,33 +645,33 @@ Autoplay can be changed in YouTube settings: Additional settings - "Hide 'Ambient mode' menu" - "'Ambient mode' menu is hidden." - "'Ambient mode' menu is shown." - "Hide 'Help & feedback' menu" - "'Help & feedback' menu is hidden." - "'Help & feedback' menu is shown." - "Hide 'Listen with YouTube Music' menu" - "'Listen with YouTube Music' menu is hidden." - "'Listen with YouTube Music' menu is shown." - "Hide 'Loop video' menu" - "'Loop video' menu is hidden." - "'Loop video' menu is shown." - "Hide 'Picture-in-picture' menu" - "'Picture-in-picture' menu is hidden." - "'Picture-in-picture' menu is shown." - "Hide 'Listening controls' menu" - "'Listening controls' menu is hidden." - "'Listening controls' menu is shown." - "Hide 'Stable volume' menu" - "'Stable volume' menu is shown." - "'Stable volume' menu is hidden." - "Hide 'Stats for nerds' menu" - "'Stats for nerds' menu is hidden." - "'Stats for nerds' menu is shown." - "Hide 'Watch in VR' menu" - "'Watch in VR' menu is hidden." - "'Watch in VR' menu is shown." + Hide Ambient mode menu + Ambient mode menu is hidden. + Ambient mode menu is shown. + Hide Help & feedback menu + Help & feedback menu is hidden. + Help & feedback menu is shown. + Hide Listen with YouTube Music menu + Listen with YouTube Music menu is hidden. + Listen with YouTube Music menu is shown. + Hide Loop video menu + Loop video menu is hidden. + Loop video menu is shown. + Hide Picture-in-picture menu + Picture-in-picture menu is hidden. + Picture-in-picture menu is shown. + Hide Premium controls menu + Premium controls menu is hidden. + Premium controls menu is shown. + Hide Stable volume menu + Stable volume menu is shown. + Stable volume menu is hidden. + Hide Stats for nerds menu + Stats for nerds menu is hidden. + Stats for nerds menu is shown. + Hide Watch in VR menu + Watch in VR menu is hidden. + Watch in VR menu is shown. Fullscreen @@ -699,31 +699,31 @@ Limitation: Video title disappears when clicked." Hide quick actions container Quick actions container is hidden. Quick actions container is shown. - Hide comment button - Comment button is hidden. - Comment button is shown. - Hide dislike button + Hide Comments button + Comments button is hidden. + Comments button is shown. + Hide Dislike button Dislike button is hidden. Dislike button is shown. - Hide like button + Hide Like button Like button is hidden. Like button is shown. - Hide live chat button + Hide Live chat button Live chat button is hidden. Live chat button is shown. - Hide more button + Hide More button More button is hidden. More button is shown. - Hide open mix playlist button + Hide Open mix playlist button Open mix playlist button is hidden. Open mix playlist button is shown. - Hide open playlist button + Hide Open playlist button Open playlist button is hidden. Open playlist button is shown. - Hide save to playlist button - Save to playlist button is hidden. - Save to playlist button is shown. - Hide share button + Hide Save button + Save button is hidden. + Save button is shown. + Hide Share button Share button is hidden. Share button is shown. Quick actions top margin @@ -771,22 +771,22 @@ Limitation: Video title disappears when clicked." Player buttons Hide or show buttons in the video player. - Hide autoplay button + Hide Autoplay button Autoplay button is hidden. Autoplay button is shown. - Hide captions button + Hide Captions button Captions button is hidden. Captions button is shown. - Hide cast button + Hide Cast button Cast button is hidden. Cast button is shown. Hide collapse button Collapse button is hidden. Collapse button is shown. - Hide fullscreen button + Hide Fullscreen button Fullscreen button is hidden. Fullscreen button is shown. - Hide previous & next button + Hide previous & next buttons Buttons are hidden. Buttons are shown. Hide YouTube Music button @@ -1087,9 +1087,9 @@ Limitation: Official headers in search results will be hidden." Disable HDR video HDR video is disabled. HDR video is enabled. - Disable playback speed in live stream - Default playback speed is disabled in live stream. - Default playback speed is enabled in live stream. + Disable playback speed for live streams + Default playback speed is disabled for live streams. + Default playback speed is enabled for live streams. Enable custom playback speed Custom playback speed is enabled. Custom playback speed is disabled. @@ -1107,7 +1107,7 @@ Limitation: Official headers in search results will be hidden." Restore old video quality menu Old video quality menu is shown. Old video quality menu is not shown. - Enable shorts default playback speed + Enable Shorts default playback speed Default playback speed applies to Shorts. Default playback speed does not apply to Shorts. Skipped preloaded buffer. @@ -1149,14 +1149,14 @@ A different codec will be applied after about 20 seconds of buffering." Limitation: Dislikes may not appear if the user is not logged in or in incognito mode." Dislikes hidden on Shorts. Dislikes as percentage - Dislikes shown as percentage. - Dislikes shown as number. + Dislikes shown as a percentage. + Dislikes shown as a number. Compact like button Like button styled for minimum width. Like button styled for best appearance. - Show a toast if API is not available - Toast is shown if Return YouTube Dislike is not available. - Toast is not shown if Return YouTube Dislike is not available. + Show a toast if API is unavailable + Toast is shown if Return YouTube Dislike is unavailable. + Toast is not shown if Return YouTube Dislike is unavailable. About @@ -1280,9 +1280,9 @@ Limitation: Dislikes may not appear if the user is not logged in or in incognito General - Show a toast if API is not available - Toast is shown if SponsorBlock is not available. - Toast is not shown if SponsorBlock is not available. + Show a toast if API is unavailable + Toast is shown if SponsorBlock is unavailable. + Toast is not shown if SponsorBlock is unavailable. Enable skip count tracking Lets the SponsorBlock leaderboard know how much time is saved. A message is sent to the leaderboard each time a segment is skipped. Skip count tracking is not enabled. @@ -1347,7 +1347,7 @@ Limitation: Dislikes may not appear if the user is not logged in or in incognito Stats - Stats temporarily not available (API is down). + Stats temporarily unavailable (API is down). Loading... SponsorBlock is disabled. Your username: <b>%s</b> From fb2a571fc19f76176b54eeb512543a5898925329 Mon Sep 17 00:00:00 2001 From: KobeW50 <84587632+KobeW50@users.noreply.github.com> Date: Tue, 28 May 2024 14:50:31 -0400 Subject: [PATCH 6/9] Make "For you shelves" singular --- src/main/resources/youtube/settings/host/values/strings.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/resources/youtube/settings/host/values/strings.xml b/src/main/resources/youtube/settings/host/values/strings.xml index 4f63a0c81d..401dc9a1ca 100644 --- a/src/main/resources/youtube/settings/host/values/strings.xml +++ b/src/main/resources/youtube/settings/host/values/strings.xml @@ -177,9 +177,9 @@ Store" Hide channel profile links Links at the top of channel profiles are hidden. Links at the top of channel profiles are shown. - "Hide 'For You' shelves" - "'For You' shelves are hidden." - "'For You' shelves are shown." + "Hide 'For You' shelf" + "'For You' shelf is hidden." + "'For You' shelf is shown." Community posts From be6f36bfb63868c434d9c299884929bd52dcd9f7 Mon Sep 17 00:00:00 2001 From: KobeW50 <84587632+KobeW50@users.noreply.github.com> Date: Wed, 29 May 2024 16:50:00 -0400 Subject: [PATCH 7/9] Plural nouns in patch names and descriptions --- .../general/oldstylelibraryshelf/OldStyleLibraryShelfPatch.kt | 2 +- .../music/general/redirection/DislikeRedirectionPatch.kt | 2 +- .../app/revanced/patches/music/misc/codecs/OpusCodecPatch.kt | 4 ++-- .../patches/music/player/replace/ReplaceCastButtonPatch.kt | 4 ++-- .../patches/youtube/layout/dimming/ShortsDimmingPatch.kt | 2 +- .../patches/youtube/player/comments/CommentsComponentPatch.kt | 2 +- .../patches/youtube/shorts/repeat/ShortsRepeatPatch.kt | 2 +- .../shorts/startupshortsreset/ResumingShortsOnStartupPatch.kt | 2 +- 8 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/main/kotlin/app/revanced/patches/music/general/oldstylelibraryshelf/OldStyleLibraryShelfPatch.kt b/src/main/kotlin/app/revanced/patches/music/general/oldstylelibraryshelf/OldStyleLibraryShelfPatch.kt index c49ac95015..4beb0b2f98 100644 --- a/src/main/kotlin/app/revanced/patches/music/general/oldstylelibraryshelf/OldStyleLibraryShelfPatch.kt +++ b/src/main/kotlin/app/revanced/patches/music/general/oldstylelibraryshelf/OldStyleLibraryShelfPatch.kt @@ -18,7 +18,7 @@ import com.android.tools.smali.dexlib2.iface.instruction.TwoRegisterInstruction @Suppress("unused") object OldStyleLibraryShelfPatch : BaseBytecodePatch( name = "Restore old style library shelf", - description = "Adds an option to return the library tab to the old style.", + description = "Adds an option to return the Library tab to the old style.", dependencies = setOf(SettingsPatch::class), compatiblePackages = COMPATIBLE_PACKAGE, fingerprints = setOf(BrowseIdFingerprint) diff --git a/src/main/kotlin/app/revanced/patches/music/general/redirection/DislikeRedirectionPatch.kt b/src/main/kotlin/app/revanced/patches/music/general/redirection/DislikeRedirectionPatch.kt index 83243eb6b4..ae5b6e1846 100644 --- a/src/main/kotlin/app/revanced/patches/music/general/redirection/DislikeRedirectionPatch.kt +++ b/src/main/kotlin/app/revanced/patches/music/general/redirection/DislikeRedirectionPatch.kt @@ -27,7 +27,7 @@ import com.android.tools.smali.dexlib2.iface.reference.Reference @Suppress("unused") object DislikeRedirectionPatch : BaseBytecodePatch( name = "Disable dislike redirection", - description = "Adds an option to disable redirection to the next track when clicking the dislike button.", + description = "Adds an option to disable redirection to the next track when clicking the Dislike button.", dependencies = setOf(SettingsPatch::class), compatiblePackages = COMPATIBLE_PACKAGE, fingerprints = setOf( diff --git a/src/main/kotlin/app/revanced/patches/music/misc/codecs/OpusCodecPatch.kt b/src/main/kotlin/app/revanced/patches/music/misc/codecs/OpusCodecPatch.kt index 22661d8291..af4cf2e3f2 100644 --- a/src/main/kotlin/app/revanced/patches/music/misc/codecs/OpusCodecPatch.kt +++ b/src/main/kotlin/app/revanced/patches/music/misc/codecs/OpusCodecPatch.kt @@ -8,8 +8,8 @@ import app.revanced.util.patch.BaseResourcePatch @Suppress("unused") object OpusCodecPatch : BaseResourcePatch( - name = "Enable opus codec", - description = "Adds an option to use the opus audio codec instead of the mp4a audio codec.", + name = "Enable OPUS codec", + description = "Adds an option to use the OPUS audio codec instead of the MP4A audio codec.", dependencies = setOf( OpusCodecBytecodePatch::class, SettingsPatch::class diff --git a/src/main/kotlin/app/revanced/patches/music/player/replace/ReplaceCastButtonPatch.kt b/src/main/kotlin/app/revanced/patches/music/player/replace/ReplaceCastButtonPatch.kt index 38983c31c2..3b54565c11 100644 --- a/src/main/kotlin/app/revanced/patches/music/player/replace/ReplaceCastButtonPatch.kt +++ b/src/main/kotlin/app/revanced/patches/music/player/replace/ReplaceCastButtonPatch.kt @@ -31,8 +31,8 @@ import com.android.tools.smali.dexlib2.iface.reference.MethodReference @Suppress("unused") object ReplaceCastButtonPatch : BaseBytecodePatch( - name = "Replace cast button", - description = "Adds an option to replace the cast button in the player with the \"Open music\" button.", + name = "Replace Cast button", + description = "Adds an option to replace the Cast button in the player with an Open music button.", dependencies = setOf( MainActivityResolvePatch::class, PlayerResponsePatch::class, diff --git a/src/main/kotlin/app/revanced/patches/youtube/layout/dimming/ShortsDimmingPatch.kt b/src/main/kotlin/app/revanced/patches/youtube/layout/dimming/ShortsDimmingPatch.kt index a924ee944b..f8f5e9cee0 100644 --- a/src/main/kotlin/app/revanced/patches/youtube/layout/dimming/ShortsDimmingPatch.kt +++ b/src/main/kotlin/app/revanced/patches/youtube/layout/dimming/ShortsDimmingPatch.kt @@ -8,7 +8,7 @@ import app.revanced.util.patch.BaseResourcePatch @Suppress("unused") object ShortsDimmingPatch : BaseResourcePatch( - name = "Hide shorts dimming", + name = "Hide Shorts dimming", description = "Removes, at compile time, the dimming effect at the top and bottom of Shorts videos.", dependencies = setOf(SettingsPatch::class), compatiblePackages = COMPATIBLE_PACKAGE, diff --git a/src/main/kotlin/app/revanced/patches/youtube/player/comments/CommentsComponentPatch.kt b/src/main/kotlin/app/revanced/patches/youtube/player/comments/CommentsComponentPatch.kt index a7227a4fd1..658ae6e6d2 100644 --- a/src/main/kotlin/app/revanced/patches/youtube/player/comments/CommentsComponentPatch.kt +++ b/src/main/kotlin/app/revanced/patches/youtube/player/comments/CommentsComponentPatch.kt @@ -22,7 +22,7 @@ import com.android.tools.smali.dexlib2.iface.instruction.OneRegisterInstruction @Suppress("unused") object CommentsComponentPatch : BaseBytecodePatch( - name = "Hide comments component", + name = "Hide comments components", description = "Adds options to hide components related to comments.", dependencies = setOf( LithoFilterPatch::class, diff --git a/src/main/kotlin/app/revanced/patches/youtube/shorts/repeat/ShortsRepeatPatch.kt b/src/main/kotlin/app/revanced/patches/youtube/shorts/repeat/ShortsRepeatPatch.kt index 17c57f725b..d13641551a 100644 --- a/src/main/kotlin/app/revanced/patches/youtube/shorts/repeat/ShortsRepeatPatch.kt +++ b/src/main/kotlin/app/revanced/patches/youtube/shorts/repeat/ShortsRepeatPatch.kt @@ -22,7 +22,7 @@ import com.android.tools.smali.dexlib2.iface.instruction.ReferenceInstruction @Suppress("unused") object ShortsRepeatPatch : BaseBytecodePatch( - name = "Change shorts repeat state", + name = "Change Shorts repeat state", description = "Adds an option to control whether Shorts should repeat, autoplay, or pause upon ending.", dependencies = setOf(SettingsPatch::class), compatiblePackages = COMPATIBLE_PACKAGE, diff --git a/src/main/kotlin/app/revanced/patches/youtube/shorts/startupshortsreset/ResumingShortsOnStartupPatch.kt b/src/main/kotlin/app/revanced/patches/youtube/shorts/startupshortsreset/ResumingShortsOnStartupPatch.kt index 41eb1bf174..c2dd9bd7fb 100644 --- a/src/main/kotlin/app/revanced/patches/youtube/shorts/startupshortsreset/ResumingShortsOnStartupPatch.kt +++ b/src/main/kotlin/app/revanced/patches/youtube/shorts/startupshortsreset/ResumingShortsOnStartupPatch.kt @@ -24,7 +24,7 @@ import com.android.tools.smali.dexlib2.iface.reference.MethodReference @Suppress("unused") object ResumingShortsOnStartupPatch : BaseBytecodePatch( - name = "Disable resuming shorts on startup", + name = "Disable resuming Shorts on startup", description = "Adds an option to disable the Shorts player from resuming on app startup when Shorts were last being watched.", dependencies = setOf(SettingsPatch::class), compatiblePackages = COMPATIBLE_PACKAGE, From 24bbcbba790caa5d3c2fd7994461ac6eb4645e8d Mon Sep 17 00:00:00 2001 From: inotia00 <108592928+inotia00@users.noreply.github.com> Date: Thu, 30 May 2024 11:25:49 +0900 Subject: [PATCH 8/9] change the patch name in the `Patch information` section --- .../resources/youtube/settings/xml/revanced_prefs.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/resources/youtube/settings/xml/revanced_prefs.xml b/src/main/resources/youtube/settings/xml/revanced_prefs.xml index 2b35c30af9..e0eff071da 100644 --- a/src/main/resources/youtube/settings/xml/revanced_prefs.xml +++ b/src/main/resources/youtube/settings/xml/revanced_prefs.xml @@ -613,7 +613,7 @@ - + @@ -622,8 +622,8 @@ - - + + @@ -652,7 +652,7 @@ - + From 62a5ac17fcfbc8ce912ca012ae2378b58a972aad Mon Sep 17 00:00:00 2001 From: inotia00 <108592928+inotia00@users.noreply.github.com> Date: Thu, 30 May 2024 18:52:17 +0900 Subject: [PATCH 9/9] Update RecentlyVisitedShelfPatch.kt --- .../layout/recentlyvisited/RecentlyVisitedShelfPatch.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/kotlin/app/revanced/patches/reddit/layout/recentlyvisited/RecentlyVisitedShelfPatch.kt b/src/main/kotlin/app/revanced/patches/reddit/layout/recentlyvisited/RecentlyVisitedShelfPatch.kt index 0d9a95a39e..22361979c1 100644 --- a/src/main/kotlin/app/revanced/patches/reddit/layout/recentlyvisited/RecentlyVisitedShelfPatch.kt +++ b/src/main/kotlin/app/revanced/patches/reddit/layout/recentlyvisited/RecentlyVisitedShelfPatch.kt @@ -22,8 +22,8 @@ import com.android.tools.smali.dexlib2.iface.reference.Reference @Suppress("unused") object RecentlyVisitedShelfPatch : BaseBytecodePatch( - name = "Hide recently visited shelf", - description = "Adds an option to hide the recently visited shelf in the sidebar.", + name = "Hide Recently Visited shelf", + description = "Adds an option to hide the Recently Visited shelf in the sidebar.", dependencies = setOf(SettingsPatch::class), compatiblePackages = COMPATIBLE_PACKAGE, fingerprints = setOf(CommunityDrawerPresenterFingerprint)