CLI helper functions for constructing transactions #2335
Conversation
JaredCorduan
force-pushed
the
jc/alonzo-cli-helpers
branch
from
b1c074a
to
6565807
Compare
JaredCorduan
force-pushed
the
jc/alonzo-cli-helpers
branch
from
a39afe2
to
bc7f504
Compare
JaredCorduan
changed the title
| @@ -213,6 +225,14 @@ instance | |||
| instance (CC.Crypto c) => UsesTxOut (AlonzoEra c) where | |||
| makeTxOut _proxy addr val = TxOut addr val Shelley.SNothing | |||
|
|
|||
| instance CC.Crypto c => API.CLIHelpers (AlonzoEra c) where | |||
There was a problem hiding this comment.
I guess I would slightly prefer CLI rather than CLIHelpers, for consistency with the other things (e.g. Wallet rather than WalletHelpers). And we should paint the bikeshed blue.
There was a problem hiding this comment.
I love blue! (what I love even more than blue is when I don't have to pick the color.... :) ) Happy to change the names, I think "helpers" is superfluous indeed.
|
|
||
| -- | Evaluate the execution budgets needed for all the redeemers in | ||
| -- a given transaction. If a redeemer is invalid, a failure is returned instead. | ||
| evaluateTransactionExecutionUnits :: |
There was a problem hiding this comment.
Is the intention that the Tx already has some ExUnits in the transaction redeemers, which are then ignored and we pass back appropriately sized ExUnits later (and merge them into this transaction?). In general I find the use of this function a little confusing.
There was a problem hiding this comment.
yes! I should explain that in the haddocks!!
| {-# LANGUAGE TypeApplications #-} | ||
| {-# LANGUAGE TypeFamilies #-} | ||
|
|
||
| module Shelley.Spec.Ledger.API.CLI |
There was a problem hiding this comment.
Are these just for the CLI, or can we merge into Wallet, seeing as these are needed for some Wallet functions?
There was a problem hiding this comment.
I don't know. If you think these would be better placed in Wallet, let me know!
Three are in a new class in the API module, one is Alonzo specific.
JaredCorduan
force-pushed
the
jc/alonzo-cli-helpers
branch
from
bc7f504
to
8cb491a
Compare
This PR adds four new functions to be used by the cardano-cli for constructing transactions.
Three of the new functions live in a class,
CLIHelpers, and are supported in all eras:evaluateTransactionBalance,evaluateTransactionBalance,evaluateTransactionFee. The first two contain default implementations, the class just needs to know the properminfeeandconsumedfunction to use. Finally, there is an Alonzo-specific functionevaluateTransactionExecutionUnitswhich computes the minimal execution budget for the redeemers in an Alonzo transaction.Additionally, I changed some of the surrounding code (changes separated by commit):
Languagestype is bounded and inflexibletxInfonow returns a monadic value, as given byEpochInfo mwhen converting slots to POSIX time for plutus.totalDepositsfunction that has been used since Shelley for determining the deposits needed by a given transaction now takes a predicate instead of a mapping of stake pools. Instead of providing the map, you can now use(Map.notMember pools).totExUnitsis now a standalone function instead of aHasFieldinstance.