--logging-config FILE.YAML more info and tests required #961
Assignees
Milestone
Comments
iohk-bors bot
added a commit
that referenced
this issue
Dec 9, 2019
1116: Estimate fees for joining a stake pool r=KtorZ a=Anviking # Issue Number WB-32: #1094 #1096 (Found it easier to tackle both at once) # Overview Also see commit history, but main points: - [x] Added API endpoint *GET /stake-pools/{stake-pool}/wallets/{wallet}/fee* - [x] Added `feeBalance :: CoinSelection -> Word64`. I re-use `selectCoinsForDelegation` together with `feeBalance` to implement the `joinStakePoolFee` handler. - [x] Integration tests: - STAKE_POOLS_ESTIMATE_FEE_01 - fee matches eventual cost - STAKE_POOLS_ESTIMATE_FEE_02 - empty wallet cannot estimate fee - STAKE_POOLS_ESTIMATE_FEE_03 - can't use byron wallets - STAKE_POOLS_ESTIMATE_FEE_04 - invalid pool and wallet ids <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 1149: bump versions to v2019.12.9 r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> N/A # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have bumped versions to v2019.12.9 # Comments <!-- Additional comments or screenshots to attach if any --> Known issues for the upcoming release: - #1115 - #1071 - #961 <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: KtorZ <[email protected]>
iohk-bors bot
added a commit
that referenced
this issue
Dec 9, 2019
1149: bump versions to v2019.12.9 r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> N/A # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have bumped versions to v2019.12.9 # Comments <!-- Additional comments or screenshots to attach if any --> Known issues for the upcoming release: - #1115 - #1071 - #961 <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
3 tasks
iohk-bors bot
added a commit
that referenced
this issue
Jan 9, 2020
1253: remove logging-config r=paweljakubas a=paweljakubas # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #961 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have removed logging-config # Comments <!-- Additional comments or screenshots to attach if any --> Will also remove -logging-config immediately after this PR is merged in wiki here: https://github.com/input-output-hk/cardano-wallet/wiki/Wallet-command-line-interface <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Pawel Jakubas <[email protected]>
|
In the end, we removed logging-config in #1253. wiki was also updated accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
As part of #851 there was this option provided for
launchandservecommands:The format of the file is somewhat unknown and it should be provided by iohk-monitoring team.
We need to have it documented https://github.com/input-output-hk/cardano-wallet/wiki/Wallet-command-line-interface and/or link to appropriate resource added. Also information about default values needs to be provided.
We should also have some tests illustrating the behavior of
--logging-config.Steps to Reproduce
Expected behavior
Actual behavior
Resolution Plan
PR
masterQA
The text was updated successfully, but these errors were encountered: