Variable pipelining to optimize memory usage in the wallet restoration phase #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolino
changed the title
paolino
force-pushed
the
paolino/ADP-1765/reduce-restoration-memory-footprint
branch
from
36ad806
to
002b2a4
Compare
paolino
added
the
IMPROVEMENT
HeinrichApfelmus
requested changes
May 16, 2022
Anviking
reviewed
May 16, 2022
Anviking
reviewed
May 16, 2022
paolino
force-pushed
the
paolino/ADP-1765/reduce-restoration-memory-footprint
branch
from
cfcf20f
to
66430c2
Compare
There was a problem hiding this comment.
Punchier names! ✊
For example, I have no idea how to explain the meaning and purpose of the Pipelining type succinctly. But I can explain getPipelineSize: "getPipelineSize returns the size of the pipeline that should be used after encountering the given block (height)". Hence, I recommend to inline the type names.
paolino
force-pushed
the
paolino/ADP-1765/reduce-restoration-memory-footprint
branch
from
581df10
to
af6bdd8
Compare
HeinrichApfelmus
approved these changes
May 17, 2022
There was a problem hiding this comment.
Hi @paolino
There are a few sections of the code that are in excess of our line length limit. Would it be possible to amend those before merging?
Many thanks!
Jonathan
paolino
force-pushed
the
paolino/ADP-1765/reduce-restoration-memory-footprint
branch
from
d3e17b2
to
15c6ba0
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 18, 2022
3274: Variable pipelining to optimize memory usage in the wallet restoration phase r=paolino a=paolino - I have implemented a pipelining number that depends on blockheight ### Issue Number ADP-1765 Co-authored-by: Paolo Veronelli <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
paolino/ADP-1765/reduce-restoration-memory-footprint
branch
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1765