Make sure payment template is available during coin selection and fee estimation is using it for multisig #3502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
force-pushed
the
paweljakubas/adp-2221/fee-adjustment-testnet
branch
from
8b886b2
to
93b76cb
Compare
paweljakubas
changed the title
paweljakubas
changed the title
Anviking
approved these changes
Oct 11, 2022
| @@ -1820,9 +1826,10 @@ estimateTxSize era skeleton = | |||
|
|
|||
| -- Total number of signatures the scripts require | |||
| numberOf_ScriptVkeyWitnesses | |||
| = sumVia scriptRequiredKeySigs txScripts | |||
| = sumVia scriptRequiredKeySigs txMintOrBurnScripts | |||
| + maybe 0 scriptRequiredKeySigs txPaymentTemplate | |||
There was a problem hiding this comment.
The effect of this line seems to be to: "add sizeOf_VKeyWitness * scriptRequiredKeySigs if a payment template exists."
You also seem to be adding determinePaymentTemplateSize once.
I'd guess it should rather be determinePaymentTemplateSize * nInputs * scriptRequiredKeySigs?
There was a problem hiding this comment.
indeed! Thanks Johannes!
|
bors try |
tryBuild failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 11, 2022
3502: Make sure payment template is available during coin selection and fee estimation is using it for multisig r=paweljakubas a=paweljakubas
<!--
Detail in a few bullet points the work accomplished in this PR.
Before you submit, don't forget to:
* Make sure the GitHub PR fields are correct:
✓ Set a good Title for your PR.
✓ Assign yourself to the PR.
✓ Assign one or more reviewer(s).
✓ Link to a Jira issue, and/or other GitHub issues or PRs.
✓ In the PR description delete any empty sections
and all text commented in <!--, so that this text does not appear
in merge commit messages.
* Don't waste reviewers' time:
✓ If it's a draft, select the Create Draft PR option.
✓ Self-review your changes to make sure nothing unexpected slipped through.
* Try to make your intent clear:
✓ Write a good Description that explains what this PR is meant to do.
✓ Jira will detect and link to this PR once created, but you can also
link this PR in the description of the corresponding Jira ticket.
✓ Highlight what Testing you have done.
✓ Acknowledge any changes required to the Documentation.
-->
- [x] Added script template of native script to tx skeleton and update tx size estimation basing on ledger's cddl
### Comments
Minting/delegation/validity for multisig is going to be addressed in coming PRs. At this point single/multiple output multisig txs along with metadata support should work.
<!-- Additional comments, links, or screenshots to attach, if any. -->
### Issue Number
adp-2221
<!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles.
Note: Jira issues of the form ADP- will be auto-linked. -->
Co-authored-by: Pawel Jakubas <[email protected]>
|
bors r- |
|
Canceled. |
- single output - multi output - multi-assets - validity intervals
piotr-iohk
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
It appears that with most recent commit 7402995 this fixes ADP-2221. So far I haven't seen "invalid_transaction" on submission on preview network.
Also enabled submitting tx + additional assertions on following txs from shared wallets (e2e tests):
- single output
- multi output
- multi-assets
- validity intervals
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
paweljakubas/adp-2221/fee-adjustment-testnet
branch
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments
Minting/delegation/validity for multisig is going to be addressed in coming PRs. At this point single/multiple output multisig txs along with metadata support should work.
Issue Number
adp-2221