Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkFlake should arguably not build private sub-libraries #2028

Open
michaelpj opened this issue Aug 23, 2023 · 4 comments
Open

mkFlake should arguably not build private sub-libraries #2028

michaelpj opened this issue Aug 23, 2023 · 4 comments
Labels
bug Something isn't working preserved Keep stale bot away

Comments

@michaelpj
Copy link
Collaborator

At the moment it will do, since it just picks all the components.

A typical case is something like a private library that's only used in test suites, but the test suites are disabled. We won't build the test suite, but we will build the private library!

@michaelpj michaelpj added the bug Something isn't working label Aug 23, 2023
@andreabedini
Copy link
Member

I'd naively expect we would end up building the components included in the plan.
Next step would be to check, in the case you describe, whether the private sub-lib shows up in the plan.

Copy link

stale bot commented Dec 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 22, 2023
@stale stale bot closed this as completed Feb 20, 2024
@michaelpj michaelpj removed the wontfix label Feb 20, 2024
@michaelpj
Copy link
Collaborator Author

Not stale.

@michaelpj michaelpj reopened this Feb 20, 2024
Copy link

stale bot commented Jun 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 19, 2024
@hamishmack hamishmack added the preserved Keep stale bot away label Jul 8, 2024
@stale stale bot removed the wontfix label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preserved Keep stale bot away
Projects
None yet
Development

No branches or pull requests

3 participants