Profiling settings don't seem to be passed on from build config

[michaelpj]

Setting

profiling: true

in cabal.project doesn't seem to get propagated to the Nix setup, it still builds non-profiled libraries.

Similarly, setting

build:
  library-profiling: true
  executable-profiling: true

in stack.yaml has no effect.

(Yes, I made sure my haskell.nix build was using each of those files as the source of truth when I tried it!)

[michaelpj]

Quoth Hamish:

I suspect profiling: true does not make it into the plan.json or plan-to-nix does not process it. There is a similar issue with ghc-options haskell/cabal#6343

[tscholak]

Is there a workaround?

[tscholak]

for those who follow me here:

haskell.nix/test/cabal-simple-prof/default.nix

Lines 7 to 16 in aac430c

	modules = [
	{
	# Package has no exposed modules which causes
	# haddock: No input file(s)
	packages.cabal-simple.doHaddock = false;
	packages.cabal-simple.enableExecutableProfiling = true;
	enableLibraryProfiling = true;
	# executableProfiling = false;
	}
	];

does the trick

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[michaelpj]

Still annoying

[michaelpj]

@andreabedini now we're processing the plan ourselves is this something we could fix?

[andreabedini]

I had a first look at this. AFAIU we don't try to pass the content of cabal.project to the builder, we mostly rely on the information that cabal writes in plan.json (or at least we did until #1775). Setting flags in cabal.project works because cabal puts them in plan.json.

Whether we want profiling or not does not get written in plan.json so it never reaches our builder.

This is the current state.

Now, whether or not to turn profiling on is part of ElaboratedInstallPlan, which we started using since #1775 so one could extract this information from there.

I'd be keen but I think there's quite a bit of refactoring we need to do before we get there.

MakeInstallPlan was added separately from Plan2Nix because I didn't quite get around to figure how the schema of the nix plan, so rather than risk breaking it I made MakeInstallPlan write out plan.json as usual so that Plan2Nix could keep doing its job.

I'd like to first merge these two steps, then we are fully in control of how we make the plan end to end. Then adding stuff like this is trivial.

ping @angerman @hamishmack

[michaelpj]

Right, that makes sense. I thought it might now be trivial but alas not. I guess we could consider writing out another file that contains the missing info from plan.json like ghcOptions and profiling info.

[andreabedini]

Right, that makes sense. I thought it might now be trivial but alas not. I guess we could consider writing out another file that contains the missing info from plan.json like ghcOptions and profiling info.

... or solve the technical debt and make all these problems go away :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[michaelpj]

Still very relevant