Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unit tests error on exceeding cumulative execution budget #255

Closed
KtorZ opened this issue Mar 10, 2022 · 0 comments
Closed

Make unit tests error on exceeding cumulative execution budget #255

KtorZ opened this issue Mar 10, 2022 · 0 comments
Labels
task Subtask of a bigger feature.

Comments

@KtorZ
Copy link
Collaborator

KtorZ commented Mar 10, 2022

We noticed that validateTxScriptsUnlimited we use for unit testing validators perform validation of scripts independently also considering budgets independently. That means while each validator could pass independently, they may exceed the maximum execution budget allowed for a transaction when considered altogether.

So we want to perform a second check on top of this function to look at the cumulative budget in case of success, and make sure it remains under the maximum execution budget. This will give us failure in unit tests sooner, instead of having to witness them through the end-to-end tests.

@KtorZ KtorZ added the task Subtask of a bigger feature. label Mar 10, 2022
@ghost ghost self-assigned this Apr 6, 2022
ghost pushed a commit that referenced this issue Apr 7, 2022
Interestingly, it seems that we _cannot_ ever abort a head given current limnitations...
@ghost ghost closed this as completed in 638de6e Apr 7, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Subtask of a bigger feature.
Projects
None yet
Development

No branches or pull requests

1 participant