Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap script improvements #469

Closed
dorin100 opened this issue Jun 12, 2019 · 3 comments
Closed

bootstrap script improvements #469

dorin100 opened this issue Jun 12, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dorin100
Copy link
Contributor

dorin100 commented Jun 12, 2019 •
edited
Loading

Describe the bug

  1. automatically delete the storage file (when running bootstrap script - https://github.com/input-output-hk/jormungandr/blob/master/scripts/bootstrap)
  2. add option/parameter to start the node with Faucet = UTXO Address

To Reproduce

  1. if you run the script 2 times and start the node, the second time you start the node, you will receive the below error:
Jun 12 17:27:01.704 INFO storing blockchain in '"/d/iohk/otherProjects/jormungandr/scripts/boostrap/jormungandr-storage-test/blocks.sqlite"', task: init
Jun 12 17:27:01.729 INFO restoring state at tip 34c806dc532b84cb09a3d4ce9a4f3f2eb12773e0d9cd12391d23d251666bd434, task: bootstrap
Error while loading the blockchain state
Error in the blockchain storage: block not found

Expected behavior

  1. you should not receive any error if you run the script multiple times, each time starting the node too. Basically, you do the same operations (run script, start node) so you should see the same result (node started successfully)
  2. besides the apiPort and consensus protocol, the Faucet Address Type would be a very useful parametrization for the end users.

Additional context
@vincenthz vincenthz added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 12, 2019
@vincenthz
Copy link
Member

happy to receive PR for improvement like this

@onicrom
Copy link
Contributor

onicrom commented Jun 13, 2019

I'll take a stab at this tonight after work

@onicrom onicrom mentioned this issue Jun 14, 2019
Merged
@NicolasDP
Copy link
Contributor

fixed by #498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vincenthz @onicrom @NicolasDP @dorin100