Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent tx failure and fund locking during payout caused by address network mismatch #831

Open
paluh opened this issue Feb 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@paluh
Copy link
Collaborator

paluh commented Feb 20, 2024

Runtime should prevent transaction failure when contract contains address with wrong network

Marlowe validator doesn't really care what type of network we use:

In other words it is enough (I tested this quickly) to adjust the network when we construct mustPayToAddress to make transaction valid and not lock the funds:

let addr' = Address $ V1.serialiseAddress net addr

@paluh paluh added the enhancement New feature or request label Feb 20, 2024
@paluh paluh changed the title Runtime should adjust the network part of the address in the case of mainnet/testnet address mismatch Prevent tx failure and fund locking during payout caused by address network mismatch Feb 20, 2024
@paluh paluh assigned paluh and unassigned paluh Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant