Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the user to specify the STACK_ROOT #142

Open
haitlahcen opened this issue Oct 28, 2018 · 4 comments · May be fixed by #143
Open

Allow the user to specify the STACK_ROOT #142

haitlahcen opened this issue Oct 28, 2018 · 4 comments · May be fixed by #143
Labels
enhancement

Comments

@haitlahcen
Copy link

As a user I would like to be able to specify the STACK_ROOT used by stack2nix.
Right now it is hardcoded to /tmp/s2n.

Introducing a S2N_STACK_ROOT environment variable would be helpful.
@haitlahcen haitlahcen linked a pull request Oct 29, 2018 that will close this issue
Open
@haitlahcen
Copy link
Author

I think it would be better if we could forward arguments to stack.

@domenkozar
Copy link
Contributor

I'd also prefer it to be a command line option, as that makes invocations of stack2nix more reproducible.

@haitlahcen
Copy link
Author

haitlahcen commented Nov 1, 2018 •
edited
Loading

Shouldn't we use already defined environment variables from stack then ? Like just STACK_ROOT and then command argument --stack-root ? Maybe having an argument --stack-arguments="--stack-root='...'..." to proxy stack arguments ?

@domenkozar
Copy link
Contributor

I remember there were issues using the default $STACK_ROOT, but I can't remember what it was. Maybe @jmitchell can chip in why we chose a separate hardcoded value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow the user to specifiy a custom STACK_ROOT directory haitlahcen/stack2nix
2 participants
@domenkozar @haitlahcen