From 5073136f65c3570537666b4e3fbcff6476fa5ef9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Ver=C3=ADssimo?= <211358+averissimo@users.noreply.github.com> Date: Mon, 18 Dec 2023 13:59:53 +0100 Subject: [PATCH] Adds min package version (#582) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit WIP :: parent issue: https://github.com/insightsengineering/nestdevs-tasks/issues/7 Supersede: - #517 ### 🔴 Checklist for PR Reviewer - [ ] Tag yourself next to this repo on https://github.com/insightsengineering/nestdevs-tasks/issues/7 - [ ] Package versions are the same or higher than `main` - [ ] Package list is the same - [ ] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [ ] Added entry to `NEWS.md` - [ ] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [ ] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [ ] verdepcheck * https://github.com/insightsengineering/verdepcheck/pull/24 * https://github.com/insightsengineering/verdepcheck/pull/26 - [ ] verdepcheck-action * https://github.com/insightsengineering/r-verdepcheck-action/pull/16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --- .github/workflows/scheduled.yml | 23 ++++++++++++++ DESCRIPTION | 54 ++++++++++++++++++++++++--------- NEWS.md | 3 +- 3 files changed, 64 insertions(+), 16 deletions(-) create mode 100644 .github/workflows/scheduled.yml diff --git a/.github/workflows/scheduled.yml b/.github/workflows/scheduled.yml new file mode 100644 index 000000000..6b66a892c --- /dev/null +++ b/.github/workflows/scheduled.yml @@ -0,0 +1,23 @@ +--- +name: Scheduled 🕰️ + +on: + schedule: + - cron: '45 3 * * 0' + workflow_dispatch: + +jobs: + dependency-test: + strategy: + fail-fast: false + matrix: + test-strategy: ["min_cohort", "min_isolated", "release", "max"] + uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main + name: Dependency Test - ${{ matrix.test-strategy }} 🔢 + secrets: + REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }} + GCHAT_WEBHOOK: ${{ secrets.GCHAT_WEBHOOK }} + with: + strategy: ${{ matrix.test-strategy }} + additional-env-vars: | + PKG_SYSREQS_DRY_RUN=true diff --git a/DESCRIPTION b/DESCRIPTION index 20d3593bf..93d560609 100755 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -23,33 +23,33 @@ BugReports: https://github.com/insightsengineering/chevron/issues Depends: R (>= 4.0.0) Imports: - checkmate (>= 2.0), - dplyr, + checkmate (>= 2.1.0), + dplyr (>= 1.1.0), dunlin (>= 0.1.6.9002), forcats (>= 1.0.0), formatters (>= 0.5.4), ggplot2 (>= 3.4.0), - glue, + glue (>= 1.0.0), grid, - lifecycle, - magrittr, + lifecycle (>= 0.2.0), + magrittr (>= 1.5), methods, nestcolor (>= 0.1.1), - purrr, - rlang, + purrr (>= 0.3.0), + rlang (>= 1.0.0), rlistings (>= 0.2.6), rtables (>= 0.6.5), - stringr, + stringr (>= 1.4.1), tern (>= 0.9.2), - tibble, + tibble (>= 2.0.0), utils Suggests: - knitr, - rmarkdown, - testthat (>= 3.0.0), - tidyr, - vdiffr, - withr + knitr (>= 1.42), + rmarkdown (>= 2.19), + testthat (>= 3.0.4), + tidyr (>= 0.8.3), + vdiffr (>= 1.0.0), + withr (>= 2.1.0) VignetteBuilder: knitr Remotes: @@ -59,6 +59,30 @@ Remotes: insightsengineering/rlistings@*release, insightsengineering/rtables@*release, insightsengineering/tern@*release +Config/Needs/verdepcheck: + mllg/checkmate, + tidyverse/dplyr, + insightsengineering/dunlin, + tidyverse/forcats, + insightsengineering/formatters, + tidyverse/ggplot2, + tidyverse/glue, + r-lib/lifecycle, + tidyverse/magrittr, + insightsengineering/nestcolor, + tidyverse/purrr, + r-lib/rlang, + insightsengineering/rlistings, + insightsengineering/rtables, + tidyverse/stringr, + insightsengineering/tern, + tidyverse/tibble, + yihui/knitr, + rstudio/rmarkdown, + r-lib/testthat, + tidyverse/tidyr, + r-lib/vdiffr, + r-lib/withr Config/Needs/website: insightsengineering/nesttemplate Config/testthat/edition: 3 Encoding: UTF-8 diff --git a/NEWS.md b/NEWS.md index 59e6787af..62d7f9415 100644 --- a/NEWS.md +++ b/NEWS.md @@ -8,6 +8,7 @@ * Rename the dataset `ADAETTE` in `syn_data` object to `ADSAFTTE`. * Use uppercase variable names in `AET05` and `AET05_ALL`. * The string replacing `NA` values in the tables is now controlled by the `tern_default_na_str` option set during package load. +* Specified minimal version of package dependencies. # chevron 0.2.4 @@ -68,7 +69,7 @@ switched. # chevron 0.2.0 -* Remove the usage of `dm` class of object. The chevron functions now expect list of `data.frame` as `adam_db` argument. +* Remove the usage of `dm` class of object. The chevron functions now expect list of `data.frame` as `adam_db` argument. * Remove variants in template names. * Remove deprecated `getter` functions `get_main`, `get_preprocess` and `get_postprocess`. * Simplify `pre` function and add more data checks in `main` function.