Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to lines #111

Open
denisovan31415 opened this issue Mar 2, 2022 · 3 comments · Fixed by #113
Open

Add labels to lines #111

denisovan31415 opened this issue Mar 2, 2022 · 3 comments · Fixed by #113
Assignees
Labels
discussion enhancement New feature or request

Comments

@denisovan31415
Copy link
Contributor

denisovan31415 commented Mar 2, 2022

@junlueZH
if user chooses to expand the axis range to let's say -20 to 70 then the additional ticks are displayed but don't have labels. using the spaghetti plot to illustrate. the ticks circled in red should have label of 60 and -10 respectively. I know there is no actual data at those expanded ranges but is it possible to get them labeled from the range entries of -20 to 70?

image

Originally posted by @npaszty in insightsengineering/teal.goshawk#124 (comment)

@gogonzo
Copy link
Contributor

gogonzo commented Mar 15, 2022

@npaszty requested horizontal lines to be annotated on the axis (extra tick/break). There are some questions:

  1. What if there was multiple horizontal lines and axis was dominated by these extra ticks
  2. How to do it without breaking encapsulation of the horizontal/vertical lines
  3. Should it be implemented in geom_arb_hline, geom_range_hline, ...? Then they need to go on major refactor (again)
  4. Do we need another extra argument to control the labels?
  5. Do horizontal lines need extra axis ticks to locate them precisely?

@gogonzo
Copy link
Contributor

gogonzo commented Mar 15, 2022

This issue needs proper research and design before taking in to account current geom_arb_hline, geom_range_hline, ..., etc. functions

@npaszty
Copy link
Contributor

npaszty commented Mar 16, 2022

@gogonzo @junlueZH
if this is going to be a major refactor then that doesn't sound like it's worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants