... (ellipsis) not used in t_summarytable

[denisovan31415]

t_summarytable <- function(data,
                           trt_group,
                           param_var,
                           param,
                           xaxis_var,
                           facet_var = "AVISITCD",
                           loq_flag_var = "LOQFL", 
                           ...) {

The ... is not used anyway. Should be removed along with the documentation

[nikolas-burkoff]

Not that simply removing the "..." which actually cause errors in teal.goshawk (🤯 ) here

After discussion with @gogonzo moving this to the backlog to handle after UAT.

[donyunardi]

There are two modules in tgoshawk that are using this function:

https://github.com/insightsengineering/teal.goshawk/blob/348f38eaecb68b170e3e47e583a3d6cae45cc566/R/tm_g_gh_density_distribution_plot.R#L398

https://github.com/insightsengineering/teal.goshawk/blob/348f38eaecb68b170e3e47e583a3d6cae45cc566/R/tm_g_gh_boxplot.R#L515

At first, I thought ... is used for tm_g_gh_density_distribution_plot to capture the font-size argument, but looking at code base here, it doesn't look like the value passed in ... are being executed in the function's body. I don't even see ... was captured into a list.

which means, this line has no meaning to tgoshawk and has been working for because of the ... in goshawk.

So, if we remove the ... from t_summarytable, then we have to follow it by removing this line.

Just to be safe, pinging @npaszty in case there's other concern.

[npaszty]

yes. t_summary used to present the tables below the visualizations

[donyunardi]

Thanks @npaszty.

In that case, we'll move forward with the removal of ellipsis from t_summarytable since there's no use of it.

Acceptance Criteria:

1. Remove ... argument from the t_summarytable function in goshawk
2. Remove the font-size argument in teal.goshawk::srv_g_density_distribution_plot
3. Pass R CMD check and integration test.

These two has to be done (merged) at the same time otherwise the integration test will fail.

[npaszty]

yeah, I guess I can't provide much more info than that since I haven't looked at this code for a very long time since its development/maintenance was taken over by the IE team.