Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI, the MMRM module from the [teal.gallery](https://genentech.shinyapps.io/nest_efficacy_stable/) is showing some errors as well. I tried out with different user input values. #108

Open
pawelru opened this issue Nov 21, 2023 · 3 comments
Labels

Comments

@pawelru
Copy link
Contributor

pawelru commented Nov 21, 2023

          FYI, the MMRM module from the [teal.gallery](https://genentech.shinyapps.io/nest_efficacy_stable/) is showing some errors as well. I tried out with different user input values. 
image

Originally posted by @imazubi in insightsengineering/tlg-catalog#122 (comment)

@shajoezhu
Copy link
Contributor

this can be resolved with updating the renv file

see example at https://github.com/shajoezhu/china_nest_teal_gee_mmrm_demo/blob/main/renv.lock#L2714

@pawelru
Copy link
Contributor Author

pawelru commented Nov 21, 2023

I don't think developers are expected to change .lock files. Those are auto-generated and auto-updated so it might happen that your changes will be immidiately overwritten by auto-update. Am I right @vedhav?

@pawelru pawelru added the core label Nov 21, 2023
@vedhav
Copy link
Contributor

vedhav commented Nov 21, 2023

Yes, The renv.lock files shown in the teal.gallery repo are not the package versions that are deployed in the teal.gallery demo deployments because we auto-update the package versions in the deployments every day.

  • The _stable deployments always install the teal* packages (and any GitHub packages in the renv.lock) from the latest tag (teal.gallery app code is taken from the main branch)
  • The _dev deployments always install the teal* packages from the main branch (teal.gallery app code is taken from the dev branch)

Once we deploy the apps using the CI, the last step is to commit the updated renv.lock files which is failing right now because of no permission to commit on main which is causing this false perception about the deployments. This will soon be fixed in this PR

And of course, as Paweł mentioned these renv.lock files are not meant to be updated by the developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants