Message from CRAN #210

donyunardi · 2023-12-07T06:13:27Z

Got an email from CRAN:

Warning The sender address (Prof Brian Ripley ) can not be verified, sender email address could be spoofed. Please take care to proceed.
Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_teal.widgets.html.

Please correct before 2023-12-20 to safely retain your package on CRAN.

The CRAN Team

It looks like teal.widgets is failing on some compilers and M1Mac.

chlebowa · 2023-12-07T10:29:31Z

@insightsengineering/nest-core-dev Can someone with a Mac try to reproduce?

averissimo · 2023-12-07T10:59:35Z

Pinging @vedhav as he has one.

It seems like a problem with a re-exported function in rtables::export_as_pdf from the original in formatters that uses the missing function. Very weird error as the function is not missing, it's in formatters!!

I've started fedora checks on rhub just to see if this is somehow transient

(they've been running for more than an hour, but should finish soon)

edit: updated wrong links, that was my first submission with an old version

vedhav · 2023-12-07T11:08:50Z

The function font_lcpi was made internal from the formatters package yesterday. That could be it.

averissimo · 2023-12-07T11:10:08Z

~~That has not been released to CRAN.~~

vedhav · 2023-12-07T11:12:41Z

It seems to be already there.
Also, I can reproduce this error. I get the same 3 errors while running the unit tests locally.

pawelru · 2023-12-07T11:56:27Z

It might be connected with the release of formatters (just yesterday) and not-yet rtables (already submitted?) Maybe it would be addressed by the upcoming rtables release. @shajoezhu can you please have a look at this?

@vedhav can you please run it using (i) cran formatters + cran rtables and (ii) cran formatters + main rtables and report your findings?

vedhav · 2023-12-11T15:57:59Z

Hey @pawelru sorry missed your message. Just installed them again and after testing now here are the results.
The main version of teal.widgets passes both these cases.

CRAN - formatters + rtables

Fails 4 tests

> packageVersion('formatters')
[1] ‘0.5.5’
> packageVersion('rtables')
[1] ‘0.6.6’
> packageVersion('teal.widgets')
[1] ‘0.4.1’

══ Results ═══════════════════════════════════════════════════════════════════════════════════════════════════════
Duration: 8.7 s

── Failed tests ──────────────────────────────────────────────────────────────────────────────────────────────────
Error (test-table_with_settings.R:65:9): type_download_srv_table: downloading different output types, custom name
Error in `rtables::export_as_pdf(tt = table_reactive(), file = file, paginate = input$pagination_switch,
    lpp = if (input$pagination_switch) as.numeric(input$lpp))`: unused argument (tt = table_reactive())
Backtrace:
     ▆
  1. ├─shiny::testServer(...) at test-table_with_settings.R:57:3
  2. │ ├─shiny:::withMockContext(...)
  3. │ │ ├─shiny::isolate(...)
  4. │ │ │ ├─shiny::..stacktraceoff..(...)
  5. │ │ │ └─ctx$run(...)
  6. │ │ │   ├─promises::with_promise_domain(...)
  7. │ │ │   │ └─domain$wrapSync(expr)
  8. │ │ │   ├─shiny::withReactiveDomain(...)
  9. │ │ │   │ └─promises::with_promise_domain(...)
 10. │ │ │   │   └─domain$wrapSync(expr)
 11. │ │ │   │     └─base::force(expr)
 12. │ │ │   └─env$runWith(self, func)
 13. │ │ │     └─shiny (local) contextFunc()
 14. │ │ │       └─shiny::..stacktraceon..(expr)
 15. │ │ ├─shiny::withReactiveDomain(...)
 16. │ │ │ └─promises::with_promise_domain(...)
 17. │ │ │   └─domain$wrapSync(expr)
 18. │ │ │     └─base::force(expr)
 19. │ │ └─withr::with_options(...)
 20. │ │   └─base::force(code)
 21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
 22. ├─testthat::expect_true(file.exists(output$data_download)) at test-table_with_settings.R:65:9
 23. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
 24. │   └─rlang::eval_bare(expr, quo_get_env(quo))
 25. ├─base::file.exists(output$data_download)
 26. ├─output$data_download
 27. └─shiny:::`$.shinyoutput`(output, data_download)
 28.   └─.subset2(x, "impl")$getOutput(name)
 29.     └─private$renderFile(self$ns(name), download)
 30.       └─download$content(file)

Error (test-table_with_settings.R:83:9): type_download_srv_table: downloading different output types, no name
Error in `rtables::export_as_pdf(tt = table_reactive(), file = file, paginate = input$pagination_switch,
    lpp = if (input$pagination_switch) as.numeric(input$lpp))`: unused argument (tt = table_reactive())
Backtrace:
     ▆
  1. ├─shiny::testServer(...) at test-table_with_settings.R:76:3
  2. │ ├─shiny:::withMockContext(...)
  3. │ │ ├─shiny::isolate(...)
  4. │ │ │ ├─shiny::..stacktraceoff..(...)
  5. │ │ │ └─ctx$run(...)
  6. │ │ │   ├─promises::with_promise_domain(...)
  7. │ │ │   │ └─domain$wrapSync(expr)
  8. │ │ │   ├─shiny::withReactiveDomain(...)
  9. │ │ │   │ └─promises::with_promise_domain(...)
 10. │ │ │   │   └─domain$wrapSync(expr)
 11. │ │ │   │     └─base::force(expr)
 12. │ │ │   └─env$runWith(self, func)
 13. │ │ │     └─shiny (local) contextFunc()
 14. │ │ │       └─shiny::..stacktraceon..(expr)
 15. │ │ ├─shiny::withReactiveDomain(...)
 16. │ │ │ └─promises::with_promise_domain(...)
 17. │ │ │   └─domain$wrapSync(expr)
 18. │ │ │     └─base::force(expr)
 19. │ │ └─withr::with_options(...)
 20. │ │   └─base::force(code)
 21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
 22. ├─testthat::expect_true(file.exists(output$data_download)) at test-table_with_settings.R:83:9
 23. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
 24. │   └─rlang::eval_bare(expr, quo_get_env(quo))
 25. ├─base::file.exists(output$data_download)
 26. ├─output$data_download
 27. └─shiny:::`$.shinyoutput`(output, data_download)
 28.   └─.subset2(x, "impl")$getOutput(name)
 29.     └─private$renderFile(self$ns(name), download)
 30.       └─download$content(file)

Error (test-table_with_settings.R:102:9): type_download_srv_table: downloading different output types, pagination
Error in `rtables::export_as_pdf(tt = table_reactive(), file = file, paginate = input$pagination_switch,
    lpp = if (input$pagination_switch) as.numeric(input$lpp))`: unused argument (tt = table_reactive())
Backtrace:
     ▆
  1. ├─shiny::testServer(...) at test-table_with_settings.R:93:3
  2. │ ├─shiny:::withMockContext(...)
  3. │ │ ├─shiny::isolate(...)
  4. │ │ │ ├─shiny::..stacktraceoff..(...)
  5. │ │ │ └─ctx$run(...)
  6. │ │ │   ├─promises::with_promise_domain(...)
  7. │ │ │   │ └─domain$wrapSync(expr)
  8. │ │ │   ├─shiny::withReactiveDomain(...)
  9. │ │ │   │ └─promises::with_promise_domain(...)
 10. │ │ │   │   └─domain$wrapSync(expr)
 11. │ │ │   │     └─base::force(expr)
 12. │ │ │   └─env$runWith(self, func)
 13. │ │ │     └─shiny (local) contextFunc()
 14. │ │ │       └─shiny::..stacktraceon..(expr)
 15. │ │ ├─shiny::withReactiveDomain(...)
 16. │ │ │ └─promises::with_promise_domain(...)
 17. │ │ │   └─domain$wrapSync(expr)
 18. │ │ │     └─base::force(expr)
 19. │ │ └─withr::with_options(...)
 20. │ │   └─base::force(code)
 21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
 22. ├─testthat::expect_true(file.exists(output$data_download)) at test-table_with_settings.R:102:9
 23. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
 24. │   └─rlang::eval_bare(expr, quo_get_env(quo))
 25. ├─base::file.exists(output$data_download)
 26. ├─output$data_download
 27. └─shiny:::`$.shinyoutput`(output, data_download)
 28.   └─.subset2(x, "impl")$getOutput(name)
 29.     └─private$renderFile(self$ns(name), download)
 30.       └─download$content(file)

Failure (test-table_with_settings_ui.R:21:3): Table with settings: UI screenshots
Snapshot of `file` to 'table_with_settings_ui/tws-final_values.json' has changed
Run `testthat::snapshot_review('table_with_settings_ui/')` to review changes
Backtrace:
    ▆
 1. └─app$expect_values(screenshot_args = FALSE, name = "final_values") at test-table_with_settings_ui.R:21:3
 2.   └─shinytest2:::app_expect_values(...)
 3.     └─shinytest2:::app__expect_snapshot_file(...)
 4.       ├─base::withCallingHandlers(...)
 5.       └─testthat::expect_snapshot_file(...)

[ FAIL 4 | WARN 2 | SKIP 0 | PASS 201 ]

main formatters + rtables

Fails 5 tests

> packageVersion('formatters')
[1] ‘0.5.5.9000’
> packageVersion('rtables')
[1] ‘0.6.6.9000’
> packageVersion('teal.widgets')
[1] ‘0.4.1’

══ Results ═══════════════════════════════════════════════════════════════════════════════════════════════════════
Duration: 10.1 s

── Failed tests ──────────────────────────────────────────────────────────────────────────────────────────────────
Error (test-plot_with_settings.R:91:15): print_plot is able to plot different types of graphics
Error in `UseMethod("depth")`: no applicable method for 'depth' applied to an object of class "NULL"
Backtrace:
     ▆
  1. ├─testthat::expect_true(...) at test-plot_with_settings.R:90:5
  2. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
  3. │   └─rlang::eval_bare(expr, quo_get_env(quo))
  4. ├─teal.widgets:::is_draw(...)
  5. │ └─teal.widgets (local) plot_fun() at tests/testthat/helpers-with-settings.R:91:3
  6. │   └─teal.widgets:::print_plot(plot_funs[[p]], plot_types[[p]]) at test-plot_with_settings.R:91:15
  7. │     ├─base::print(plot()) at teal.widgets/R/plot_with_settings.R:662:3
  8. │     └─ggplot2:::print.ggplot(plot())
  9. │       ├─grid::grid.draw(gtable)
 10. │       └─grid:::grid.draw.gTree(gtable)
 11. │         └─grDevices::recordGraphics(drawGTree(x), list(x = x), getNamespace("grid"))
 12. └─grid:::drawGTree(x)
 13.   ├─grid:::postDraw(x)
 14.   └─grid:::postDraw.grob(x)
 15.     ├─grid:::popgrobvp(x$vp)
 16.     └─grid:::popgrobvp.viewport(x$vp)
 17.       └─grid::upViewport(depth(vp), recording = FALSE)
 18.         └─grid::depth(path)

Error (test-table_with_settings.R:65:9): type_download_srv_table: downloading different output types, custom name
Error in `rtables::export_as_pdf(tt = table_reactive(), file = file, paginate = input$pagination_switch,
    lpp = if (input$pagination_switch) as.numeric(input$lpp))`: unused argument (tt = table_reactive())
Backtrace:
     ▆
  1. ├─shiny::testServer(...) at test-table_with_settings.R:57:3
  2. │ ├─shiny:::withMockContext(...)
  3. │ │ ├─shiny::isolate(...)
  4. │ │ │ ├─shiny::..stacktraceoff..(...)
  5. │ │ │ └─ctx$run(...)
  6. │ │ │   ├─promises::with_promise_domain(...)
  7. │ │ │   │ └─domain$wrapSync(expr)
  8. │ │ │   ├─shiny::withReactiveDomain(...)
  9. │ │ │   │ └─promises::with_promise_domain(...)
 10. │ │ │   │   └─domain$wrapSync(expr)
 11. │ │ │   │     └─base::force(expr)
 12. │ │ │   └─env$runWith(self, func)
 13. │ │ │     └─shiny (local) contextFunc()
 14. │ │ │       └─shiny::..stacktraceon..(expr)
 15. │ │ ├─shiny::withReactiveDomain(...)
 16. │ │ │ └─promises::with_promise_domain(...)
 17. │ │ │   └─domain$wrapSync(expr)
 18. │ │ │     └─base::force(expr)
 19. │ │ └─withr::with_options(...)
 20. │ │   └─base::force(code)
 21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
 22. ├─testthat::expect_true(file.exists(output$data_download)) at test-table_with_settings.R:65:9
 23. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
 24. │   └─rlang::eval_bare(expr, quo_get_env(quo))
 25. ├─base::file.exists(output$data_download)
 26. ├─output$data_download
 27. └─shiny:::`$.shinyoutput`(output, data_download)
 28.   └─.subset2(x, "impl")$getOutput(name)
 29.     └─private$renderFile(self$ns(name), download)
 30.       └─download$content(file)

Error (test-table_with_settings.R:83:9): type_download_srv_table: downloading different output types, no name
Error in `rtables::export_as_pdf(tt = table_reactive(), file = file, paginate = input$pagination_switch,
    lpp = if (input$pagination_switch) as.numeric(input$lpp))`: unused argument (tt = table_reactive())
Backtrace:
     ▆
  1. ├─shiny::testServer(...) at test-table_with_settings.R:76:3
  2. │ ├─shiny:::withMockContext(...)
  3. │ │ ├─shiny::isolate(...)
  4. │ │ │ ├─shiny::..stacktraceoff..(...)
  5. │ │ │ └─ctx$run(...)
  6. │ │ │   ├─promises::with_promise_domain(...)
  7. │ │ │   │ └─domain$wrapSync(expr)
  8. │ │ │   ├─shiny::withReactiveDomain(...)
  9. │ │ │   │ └─promises::with_promise_domain(...)
 10. │ │ │   │   └─domain$wrapSync(expr)
 11. │ │ │   │     └─base::force(expr)
 12. │ │ │   └─env$runWith(self, func)
 13. │ │ │     └─shiny (local) contextFunc()
 14. │ │ │       └─shiny::..stacktraceon..(expr)
 15. │ │ ├─shiny::withReactiveDomain(...)
 16. │ │ │ └─promises::with_promise_domain(...)
 17. │ │ │   └─domain$wrapSync(expr)
 18. │ │ │     └─base::force(expr)
 19. │ │ └─withr::with_options(...)
 20. │ │   └─base::force(code)
 21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
 22. ├─testthat::expect_true(file.exists(output$data_download)) at test-table_with_settings.R:83:9
 23. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
 24. │   └─rlang::eval_bare(expr, quo_get_env(quo))
 25. ├─base::file.exists(output$data_download)
 26. ├─output$data_download
 27. └─shiny:::`$.shinyoutput`(output, data_download)
 28.   └─.subset2(x, "impl")$getOutput(name)
 29.     └─private$renderFile(self$ns(name), download)
 30.       └─download$content(file)

Error (test-table_with_settings.R:102:9): type_download_srv_table: downloading different output types, pagination
Error in `rtables::export_as_pdf(tt = table_reactive(), file = file, paginate = input$pagination_switch,
    lpp = if (input$pagination_switch) as.numeric(input$lpp))`: unused argument (tt = table_reactive())
Backtrace:
     ▆
  1. ├─shiny::testServer(...) at test-table_with_settings.R:93:3
  2. │ ├─shiny:::withMockContext(...)
  3. │ │ ├─shiny::isolate(...)
  4. │ │ │ ├─shiny::..stacktraceoff..(...)
  5. │ │ │ └─ctx$run(...)
  6. │ │ │   ├─promises::with_promise_domain(...)
  7. │ │ │   │ └─domain$wrapSync(expr)
  8. │ │ │   ├─shiny::withReactiveDomain(...)
  9. │ │ │   │ └─promises::with_promise_domain(...)
 10. │ │ │   │   └─domain$wrapSync(expr)
 11. │ │ │   │     └─base::force(expr)
 12. │ │ │   └─env$runWith(self, func)
 13. │ │ │     └─shiny (local) contextFunc()
 14. │ │ │       └─shiny::..stacktraceon..(expr)
 15. │ │ ├─shiny::withReactiveDomain(...)
 16. │ │ │ └─promises::with_promise_domain(...)
 17. │ │ │   └─domain$wrapSync(expr)
 18. │ │ │     └─base::force(expr)
 19. │ │ └─withr::with_options(...)
 20. │ │   └─base::force(code)
 21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
 22. ├─testthat::expect_true(file.exists(output$data_download)) at test-table_with_settings.R:102:9
 23. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
 24. │   └─rlang::eval_bare(expr, quo_get_env(quo))
 25. ├─base::file.exists(output$data_download)
 26. ├─output$data_download
 27. └─shiny:::`$.shinyoutput`(output, data_download)
 28.   └─.subset2(x, "impl")$getOutput(name)
 29.     └─private$renderFile(self$ns(name), download)
 30.       └─download$content(file)

Failure (test-table_with_settings_ui.R:21:3): Table with settings: UI screenshots
Snapshot of `file` to 'table_with_settings_ui/tws-final_values.json' has changed
Run `testthat::snapshot_review('table_with_settings_ui/')` to review changes
Backtrace:
    ▆
 1. └─app$expect_values(screenshot_args = FALSE, name = "final_values") at test-table_with_settings_ui.R:21:3
 2.   └─shinytest2:::app_expect_values(...)
 3.     └─shinytest2:::app__expect_snapshot_file(...)
 4.       ├─base::withCallingHandlers(...)
 5.       └─testthat::expect_snapshot_file(...)

[ FAIL 5 | WARN 0 | SKIP 0 | PASS 195 ]

donyunardi · 2023-12-11T19:07:51Z

I have intel mac and here's what I see

for CRAN formatters + main rtables + teal.widgets checked-out at v0.4.1. 4 fails:

══ Results ═════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Duration: 17.0 s

── Failed tests ────────────────────────────────────────────────────────────────────────────────────────────────────────────
Failure (test-table_with_settings_ui.R:21:3): Table with settings: UI screenshots
Snapshot of `file` to 'table_with_settings_ui/tws-final_values.json' has changed
Run `testthat::snapshot_review('table_with_settings_ui/')` to review changes
Backtrace:
    ▆
 1. └─app$expect_values(screenshot_args = FALSE, name = "final_values") at test-table_with_settings_ui.R:21:3
 2.   └─shinytest2:::app_expect_values(...)
 3.     └─shinytest2:::app__expect_snapshot_file(...)
 4.       ├─base::withCallingHandlers(...)
 5.       └─testthat::expect_snapshot_file(...)

Error (test-table_with_settings.R:57:3): type_download_srv_table: downloading different output types, custom name
Error in `rtables::export_as_pdf(tt = table_reactive(), file = file, paginate = input$pagination_switch, 
    lpp = if (input$pagination_switch) as.numeric(input$lpp))`: unused argument (tt = table_reactive())
Backtrace:
     ▆
  1. ├─shiny::testServer(...) at test-table_with_settings.R:57:3
  2. │ ├─shiny:::withMockContext(...)
  3. │ │ ├─shiny::isolate(...)
  4. │ │ │ ├─shiny::..stacktraceoff..(...)
  5. │ │ │ └─ctx$run(...)
  6. │ │ │   ├─promises::with_promise_domain(...)
  7. │ │ │   │ └─domain$wrapSync(expr)
  8. │ │ │   ├─shiny::withReactiveDomain(...)
  9. │ │ │   │ └─promises::with_promise_domain(...)
 10. │ │ │   │   └─domain$wrapSync(expr)
 11. │ │ │   │     └─base::force(expr)
 12. │ │ │   └─env$runWith(self, func)
 13. │ │ │     └─shiny (local) contextFunc()
 14. │ │ │       └─shiny::..stacktraceon..(expr)
 15. │ │ ├─shiny::withReactiveDomain(...)
 16. │ │ │ └─promises::with_promise_domain(...)
 17. │ │ │   └─domain$wrapSync(expr)
 18. │ │ │     └─base::force(expr)
 19. │ │ └─withr::with_options(...)
 20. │ │   └─base::force(code)
 21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
 22. ├─testthat::expect_true(file.exists(output$data_download)) at test-table_with_settings.R:65:9
 23. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
 24. │   └─rlang::eval_bare(expr, quo_get_env(quo))
 25. ├─base::file.exists(output$data_download)
 26. ├─output$data_download
 27. └─shiny:::`$.shinyoutput`(output, data_download)
 28.   └─.subset2(x, "impl")$getOutput(name)
 29.     └─private$renderFile(self$ns(name), download)
 30.       └─download$content(file)

Error (test-table_with_settings.R:76:3): type_download_srv_table: downloading different output types, no name
Error in `rtables::export_as_pdf(tt = table_reactive(), file = file, paginate = input$pagination_switch, 
    lpp = if (input$pagination_switch) as.numeric(input$lpp))`: unused argument (tt = table_reactive())
Backtrace:
     ▆
  1. ├─shiny::testServer(...) at test-table_with_settings.R:76:3
  2. │ ├─shiny:::withMockContext(...)
  3. │ │ ├─shiny::isolate(...)
  4. │ │ │ ├─shiny::..stacktraceoff..(...)
  5. │ │ │ └─ctx$run(...)
  6. │ │ │   ├─promises::with_promise_domain(...)
  7. │ │ │   │ └─domain$wrapSync(expr)
  8. │ │ │   ├─shiny::withReactiveDomain(...)
  9. │ │ │   │ └─promises::with_promise_domain(...)
 10. │ │ │   │   └─domain$wrapSync(expr)
 11. │ │ │   │     └─base::force(expr)
 12. │ │ │   └─env$runWith(self, func)
 13. │ │ │     └─shiny (local) contextFunc()
 14. │ │ │       └─shiny::..stacktraceon..(expr)
 15. │ │ ├─shiny::withReactiveDomain(...)
 16. │ │ │ └─promises::with_promise_domain(...)
 17. │ │ │   └─domain$wrapSync(expr)
 18. │ │ │     └─base::force(expr)
 19. │ │ └─withr::with_options(...)
 20. │ │   └─base::force(code)
 21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
 22. ├─testthat::expect_true(file.exists(output$data_download)) at test-table_with_settings.R:83:9
 23. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
 24. │   └─rlang::eval_bare(expr, quo_get_env(quo))
 25. ├─base::file.exists(output$data_download)
 26. ├─output$data_download
 27. └─shiny:::`$.shinyoutput`(output, data_download)
 28.   └─.subset2(x, "impl")$getOutput(name)
 29.     └─private$renderFile(self$ns(name), download)
 30.       └─download$content(file)

Error (test-table_with_settings.R:93:3): type_download_srv_table: downloading different output types, pagination
Error in `rtables::export_as_pdf(tt = table_reactive(), file = file, paginate = input$pagination_switch, 
    lpp = if (input$pagination_switch) as.numeric(input$lpp))`: unused argument (tt = table_reactive())
Backtrace:
     ▆
  1. ├─shiny::testServer(...) at test-table_with_settings.R:93:3
  2. │ ├─shiny:::withMockContext(...)
  3. │ │ ├─shiny::isolate(...)
  4. │ │ │ ├─shiny::..stacktraceoff..(...)
  5. │ │ │ └─ctx$run(...)
  6. │ │ │   ├─promises::with_promise_domain(...)
  7. │ │ │   │ └─domain$wrapSync(expr)
  8. │ │ │   ├─shiny::withReactiveDomain(...)
  9. │ │ │   │ └─promises::with_promise_domain(...)
 10. │ │ │   │   └─domain$wrapSync(expr)
 11. │ │ │   │     └─base::force(expr)
 12. │ │ │   └─env$runWith(self, func)
 13. │ │ │     └─shiny (local) contextFunc()
 14. │ │ │       └─shiny::..stacktraceon..(expr)
 15. │ │ ├─shiny::withReactiveDomain(...)
 16. │ │ │ └─promises::with_promise_domain(...)
 17. │ │ │   └─domain$wrapSync(expr)
 18. │ │ │     └─base::force(expr)
 19. │ │ └─withr::with_options(...)
 20. │ │   └─base::force(code)
 21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
 22. ├─testthat::expect_true(file.exists(output$data_download)) at test-table_with_settings.R:102:9
 23. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
 24. │   └─rlang::eval_bare(expr, quo_get_env(quo))
 25. ├─base::file.exists(output$data_download)
 26. ├─output$data_download
 27. └─shiny:::`$.shinyoutput`(output, data_download)
 28.   └─.subset2(x, "impl")$getOutput(name)
 29.     └─private$renderFile(self$ns(name), download)
 30.       └─download$content(file)

[ FAIL 4 | WARN 0 | SKIP 0 | PASS 201 ]

FYI rtables just released 0.6.6 3 days ago so checking on main is similar with checking on CRAN.

We already addressed unused argument (tt = table_reactive()) error, with PR #209.
And, I don't see the error Run testthat::snapshot_review('table_with_settings_ui/') to review changes with current teal.widgets main.

Running another test:

`main` teal.widgets passed with CRAN rtables + CRAN formatters

ℹ Testing teal.widgets
✔ | F W S  OK | Context
✔ |        33 | ggplot2_args                                                                                                
✔ |         7 | optionalInput                                                                                               
✔ |         6 | plot_with_settings_ui [6.7s]                                                                                
✔ |        72 | plot_with_settings [3.8s]                                                                                   
✔ |        11 | standard_layout                                                                                             
✔ |        30 | table_args                                                                                                  
✔ |         1 | table_with_settings_ui [3.4s]                                                                               
⠸ |        24 | table_with_settings                                                                                         
Error in pag_indices_inner(pagdf = mf_rinfo(mpf), rlpp = calc_rlpp(pg_size_spec,  : 
  Lines of repeated context (plus header materials) larger than specified lines per page
✔ |        27 | table_with_settings [2.3s]                                                                                  
✔ |         5 | utils                                                                                                       
✔ |        16 | verbatim_popup                                                                                              

══ Results ═════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Duration: 17.1 s

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 208 ]

There is this message/error but didn't fail the test:

Error in pag_indices_inner(pagdf = mf_rinfo(mpf), rlpp = calc_rlpp(pg_size_spec,  : 
  Lines of repeated context (plus header materials) larger than specified lines per page

@vedhav are you able to reproduce this?
Also, how do we test against r-devel?

At this point, I feel that releasing teal.widgets 0.4.2 would be our first move.
I assumed the reviewer would run the check again and if anything fails, they would communicate it to us.
We have 9 more days to send the update.

vedhav · 2023-12-12T04:44:27Z

@donyunardi Yes, I am able to get the same error message Error in pag_indices_inner ... when testing the main version of teal.widgets.
You can install the r-devel version from here. I recommend using RSwitch which helps in switching between different R versions easy (make sure to run pkgutil --forget org.R-project.arm64.R.fw.pkg or pkgutil --forget org.R-project.x86_64.R.fw.pkg before installing, else the install will overwrite your existing R installation)
Also, make sure to install the deval version of bioconductor: BiocManager::install(version = "devel")
Finally, some of the R packages might require compiling the C/C++/Fortran code so make sure that you have the compilers along with the configuration in the ~/.R/Makevars file. I use gcc and gofortran and this is my config after I installed them using brew

FC = /opt/homebrew/Cellar/gcc/13.2.0/bin/gfortran
F77 = /opt/homebrew/Cellar/gcc/13.2.0/bin/gfortran
FLIBS = -L/opt/homebrew/Cellar/gcc/13.2.0/lib/gcc/13

pawelru · 2023-12-12T08:48:35Z

And, I don't see the error Run testthat::snapshot_review('table_with_settings_ui/') to review changes with current teal.widgets main.

Note that snapshot tests are excluded on CRAN by default so this should not appear there. You have to disable (i.e. not add) --as-cran flag to trigger these.
These snapshot failures needs to be fixed at some point but it should not block CRAN release.

Re this:

Error in pag_indices_inner(pagdf = mf_rinfo(mpf), rlpp = calc_rlpp(pg_size_spec,  : 
  Lines of repeated context (plus header materials) larger than specified lines per page

Please just check if change in the parameters solve this. We don't want to test that functionality (it's defined and tested elsewhere) - we want to test if the flow is correct.

donyunardi · 2023-12-12T21:50:39Z

Please just check if change in the parameters solve this. We don't want to test that functionality (it's defined and tested elsewhere) - we want to test if the flow is correct.

Yes, change in the parameter solves this and the message that I mentioned Error in pag_indices_inner... only shows when running devtools::test(). This message doesn't show when running devtools::check().

I ran the latest main on r-devel as well

No error or warning

root@da361d82572e:~/insightsengineering# R CMD check teal.widgets_0.4.1.9010.tar.gz 
* using log directory ‘/root/insightsengineering/teal.widgets.Rcheck’
* using R Under development (unstable) (2023-12-09 r85665)
* using platform: x86_64-pc-linux-gnu
* R was compiled by
    gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
    GNU Fortran (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
* running under: Ubuntu 22.04.3 LTS
* using session charset: UTF-8
* checking for file ‘teal.widgets/DESCRIPTION’ ... OK
* this is package ‘teal.widgets’ version ‘0.4.1.9010’
* package encoding: UTF-8
* checking package namespace information ... OK
* checking package dependencies ...Warning: unable to access index for repository https://packagemanager.posit.co/cran/__linux__/jammy/latest/src/contrib:
  cannot open URL 'https://packagemanager.posit.co/cran/__linux__/jammy/latest/src/contrib/PACKAGES'
 OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for .dll and .exe files ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking for sufficient/correct file permissions ... OK
* checking whether package ‘teal.widgets’ can be installed ... OK
* checking installed package size ... OK
* checking package directory ... OK
* checking ‘build’ directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* checking whether the package can be loaded ... OK
* checking whether the package can be loaded with stated dependencies ... OK
* checking whether the package can be unloaded cleanly ... OK
* checking whether the namespace can be loaded with stated dependencies ... OK
* checking whether the namespace can be unloaded cleanly ... OK
* checking loading without being on the library search path ... OK
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking installed files from ‘inst/doc’ ... OK
* checking files in ‘vignettes’ ... OK
* checking examples ... OK
* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ...
  Running ‘testthat.R’
 OK
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in ‘inst/doc’ ... OK
* checking re-building of vignette outputs ... OK
* checking PDF version of manual ... OK
* DONE

Status: OK

I'll move forward to submit teal.widgets 0.4.2 to CRAN.

donyunardi · 2023-12-12T21:58:05Z

On second thought, I'll close this so we can continue with #212 with a nice CRAN release template.

donyunardi added the core label Dec 7, 2023

donyunardi self-assigned this Dec 12, 2023

donyunardi closed this as completed Dec 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Message from CRAN #210

Message from CRAN #210

donyunardi commented Dec 7, 2023

chlebowa commented Dec 7, 2023

averissimo commented Dec 7, 2023 •

edited

Loading

vedhav commented Dec 7, 2023

averissimo commented Dec 7, 2023 •

edited

Loading

vedhav commented Dec 7, 2023

pawelru commented Dec 7, 2023 •

edited

Loading

vedhav commented Dec 11, 2023 •

edited

Loading

donyunardi commented Dec 11, 2023

vedhav commented Dec 12, 2023

pawelru commented Dec 12, 2023

donyunardi commented Dec 12, 2023

donyunardi commented Dec 12, 2023

Message from CRAN #210

Message from CRAN #210

Comments

donyunardi commented Dec 7, 2023

chlebowa commented Dec 7, 2023

averissimo commented Dec 7, 2023 • edited Loading

vedhav commented Dec 7, 2023

averissimo commented Dec 7, 2023 • edited Loading

vedhav commented Dec 7, 2023

pawelru commented Dec 7, 2023 • edited Loading

vedhav commented Dec 11, 2023 • edited Loading

donyunardi commented Dec 11, 2023

vedhav commented Dec 12, 2023

pawelru commented Dec 12, 2023

donyunardi commented Dec 12, 2023

donyunardi commented Dec 12, 2023

averissimo commented Dec 7, 2023 •

edited

Loading

averissimo commented Dec 7, 2023 •

edited

Loading

pawelru commented Dec 7, 2023 •

edited

Loading

vedhav commented Dec 11, 2023 •

edited

Loading