From ed32223caafd7d2b7851c674620b551147899211 Mon Sep 17 00:00:00 2001 From: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com> Date: Thu, 8 Dec 2022 15:20:17 +0100 Subject: [PATCH 1/2] remove assertion that has conflict with goshawk https://github.com/insightsengineering/teal.widgets/issues/128 Signed-off-by: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com> --- R/plot_with_settings.R | 1 - 1 file changed, 1 deletion(-) diff --git a/R/plot_with_settings.R b/R/plot_with_settings.R index 4e860cac..0111ba5e 100644 --- a/R/plot_with_settings.R +++ b/R/plot_with_settings.R @@ -591,7 +591,6 @@ type_download_srv <- function(id, plot_reactive, plot_type, plot_w, default_w, p #' clean_brushedPoints <- function(data, brush) { # nolintr checkmate::assert_data_frame(data) - checkmate::assert_list(brush) # define original panelvar1 and panelvar2 before getting overwritten original_panelvar1 <- brush$mapping$panelvar1 From 551227addf3aa69a1f6b8ad59224cac950a61002 Mon Sep 17 00:00:00 2001 From: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com> Date: Thu, 8 Dec 2022 15:38:58 +0100 Subject: [PATCH 2/2] nullok Signed-off-by: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com> --- R/plot_with_settings.R | 1 + 1 file changed, 1 insertion(+) diff --git a/R/plot_with_settings.R b/R/plot_with_settings.R index 0111ba5e..cebb689c 100644 --- a/R/plot_with_settings.R +++ b/R/plot_with_settings.R @@ -591,6 +591,7 @@ type_download_srv <- function(id, plot_reactive, plot_type, plot_w, default_w, p #' clean_brushedPoints <- function(data, brush) { # nolintr checkmate::assert_data_frame(data) + checkmate::assert_list(brush, null.ok = TRUE) # define original panelvar1 and panelvar2 before getting overwritten original_panelvar1 <- brush$mapping$panelvar1