You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By chance, I noticed there is a function in wrap_text.R that is no longer used anywhere. I was wondering if it still makes sense to have it and/or if we should adapt/move it somewhere else. I think conceptually it is more appropriate to be a function in formatters, where I am working on a similar implementation (unaware of the above file) here: PR#46.
I am checking downstream dependencies now. For me, it is fine also to keep it as it is. I was just wondering about the possible duplication with formatters'function.
I could not find any downstream dep that uses this function (also, it was rendered internal and nothing broke).
The text was updated successfully, but these errors were encountered:
By chance, I noticed there is a function in
wrap_text.R
that is no longer used anywhere. I was wondering if it still makes sense to have it and/or if we should adapt/move it somewhere else. I think conceptually it is more appropriate to be a function informatters
, where I am working on a similar implementation (unaware of the above file) here: PR#46.The author is @waddella. Any suggestion on how to proceed @gmbecker @shajoezhu @waddella?
I am checking downstream dependencies now. For me, it is fine also to keep it as it is. I was just wondering about the possible duplication with
formatters
'function.I could not find any downstream dep that uses this function (also, it was rendered internal and nothing broke).
The text was updated successfully, but these errors were encountered: