Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pathlib.Path instead of strings for path #8

Open
flying-sheep opened this issue Nov 9, 2021 · 0 comments
Open

Use pathlib.Path instead of strings for path #8

flying-sheep opened this issue Nov 9, 2021 · 0 comments

Comments

@flying-sheep
Copy link

flying-sheep commented Nov 9, 2021 •
edited
Loading

The path attribute of your File class should be a pathlib.Path: using strings as paths is error prone as it invites using string manipulation functions to modify them (instead of path specific methods)

The type for accepting paths should be os.PathLike | str, not str, so the functions signal they accept e.g. pathlib.Paths as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flying-sheep