Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong labels in sample efficiency curves #34

Closed
matteobettini opened this issue Sep 22, 2023 · 1 comment · Fixed by #37
Closed

Wrong labels in sample efficiency curves #34

matteobettini opened this issue Sep 22, 2023 · 1 comment · Fixed by #37
Assignees
Labels
bug Something isn't working

Comments

@matteobettini
Copy link

matteobettini commented Sep 22, 2023

In the sample efficiency curves like this one from the notebook the x-axis labels will say "milions" even though the data scale is reported in units (as you can see by the 1e6 in the bottom left

Screenshot 2023-09-22 at 15 25 26

this means that for runs with less frames you will get results like

Screenshot 2023-09-22 at 15 28 10

where this run was only over 12_000 frames and not 12_000 million frames

@RuanJohn
Copy link
Collaborator

RuanJohn commented Dec 1, 2023

Hi @matteobettini, thank you for the raising the issue! Apologies for the slow reply. For some reason I didn't get notified.
I will make a fix for this.

@RuanJohn RuanJohn self-assigned this Dec 1, 2023
@RuanJohn RuanJohn added the bug Something isn't working label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants