Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues reimporting converted SharedPools not defined in the Application class #98

Open
eMaringolo opened this issue Aug 25, 2021 · 0 comments
Labels
bug Something isn't working exporting Issues related with exporting in Tonel format importing Issues related with importing from Tonel format

Comments

@eMaringolo
Copy link
Collaborator

If you define a shared pool in a class that is not that of the Application and convert it to a class (subclass of SharedPool) when exporting, when the loader tries to convert the SharedPool subclass back to a pragma declaration, it will define the pragma declaration method in the Application instead of the original class.

This causes a few issues problems:

  1. When exporting you'll lose the information of in which class the pool was declared.
  2. When loading back the loader will move the definition from one class (that originally defined) to another (the Application class).
  3. If you are running the step 2 above, and still have the original definition in 1, it will fail, because you're declaring the same pool dictionary twice (this time, in another class).

One possible way to work around this, in particular of point 1 above, is to save in the class metadata in which class was the shared pool originally declared (#vaDeclarationClass or similar).

This only affects shared pools when converting them (it is, with loader convertsSharedPools: true).

@eMaringolo eMaringolo added bug Something isn't working exporting Issues related with exporting in Tonel format importing Issues related with importing from Tonel format labels Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exporting Issues related with exporting in Tonel format importing Issues related with importing from Tonel format
Projects
None yet
Development

No branches or pull requests

1 participant