Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use kubelogin with Gitlab because of the code_verifier parameter #282

Closed
Place1 opened this issue Apr 27, 2020 · 2 comments · Fixed by #283
Closed

Can't use kubelogin with Gitlab because of the code_verifier parameter #282

Place1 opened this issue Apr 27, 2020 · 2 comments · Fixed by #283
Labels
enhancement New feature or request

Comments

@Place1
Copy link

Place1 commented Apr 27, 2020

Kubelogin is sending the code_verifier parameter which isn't supported on Gitlab.

Here's an issue on Gitlab's issue tracker: https://gitlab.com/gitlab-org/gitlab/-/issues/213643

Perhaps PKCE should not be used if the OIDC provider doesn't support it? I believe this can be determined at runtime via the discovery endpoint.

@int128 int128 added the enhancement New feature or request label May 5, 2020
@int128
Copy link
Owner

int128 commented May 5, 2020

It may possible to determine the provider supports PKCE by code_challenge_methods_supported of the discovery document as RFC8414.

For example, Google returns the following discovery document:

 "code_challenge_methods_supported": [
  "plain",
  "S256"
 ],

GitLab's discovery document does not contain code_challenge_methods_supported.

@int128
Copy link
Owner

int128 commented May 16, 2020

Would you check the new release v1.19.1? Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants