You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The above function doesn't work in 0.7.3
There is no snappy_formats.DEFAULT_FORMAT anymore. Looking at the unit tests, it seems get_decompress_functionis not used and instead a snappy.StreamCompressor is introduced.
I'm a little confused about a patch breaking all the above!
The text was updated successfully, but these errors were encountered:
Essentially since 0.7.0 (particularly #130 ), this repo is a simple thin wrapper around cramjam. At that time, many more niche features of the old library were dropped, but I have added them back in one by one on request.
I think your function is expected to work, but is apparently not tested. It sounds like you have all the context to be able to re=introduce it and make your code work as before (and add a test to make sure it doesn't happen again). Would you like to take this on?
Hi @martindurant
I don't have the bandwidth yet. For now I will stick with the older version of Snappy until one of customers actually uses Snappy. So far everybody has stuck with zip and gzip
Hello,
Seems like patch versions were used for backward incompatible changes.
Example:
I have the following function that works fine in 0.7.2:
The above function doesn't work in 0.7.3
There is no
snappy_formats.DEFAULT_FORMAT
anymore. Looking at the unit tests, it seemsget_decompress_function
is not used and instead asnappy.StreamCompressor
is introduced.I'm a little confused about a patch breaking all the above!
The text was updated successfully, but these errors were encountered: