-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): add Model #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-r-cox
force-pushed
the
add-model
branch
from
January 22, 2024 00:11
1a52460
to
9009fee
Compare
david-r-cox
force-pushed
the
add-model
branch
from
January 22, 2024 00:18
9009fee
to
2657d03
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
===========================================
+ Coverage 76.92% 88.68% +11.76%
===========================================
Files 4 10 +6
Lines 117 433 +316
===========================================
+ Hits 90 384 +294
- Misses 27 49 +22 ☔ View full report in Codecov by Sentry. |
david-r-cox
force-pushed
the
add-model
branch
2 times, most recently
from
January 22, 2024 03:42
79f6a73
to
6692ee2
Compare
david-r-cox
force-pushed
the
add-model
branch
from
January 22, 2024 06:09
6692ee2
to
cfc007f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds components of the MPS data model, including:
RowColumnValueMap
for storing matrix dataModel
from aParser
It also includes additional test cases and examples.
This lays the groundwork for being able to fully parse and represent MPS files. Additional pieces like validating the models and interpreting the data still need to be implemented.