-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance tests #98
Comments
If you want to scan a representative rootfs as part of the CI then maybe our release tarballs are a candidate? For example core-image-minimal-dev is a rootfs that is small (35M download), trivial to unpack (as it's a tarball) but actually exercises the code:
That URL won't be changing as it's a release artefact, so you can download it as part of the CI job. |
(that time is with 0.2.0 obviously) |
This sounds like a perfect real-world test setup. I'm going to flag this with the 'gsoc' tag because this might be a reasonable addition to a gsoc project proposal, although people are of course welcome to work on it outside of that scope. |
write tests using the tarballs! I'm working on a real-file test over in #99 (although it has a bug) and you can look at the existing ones for the extractors. You'd want to hide it behind a LONG_TEST flag. Once the test works at all, it'd be nice to figure out some logic for caching results so that you can compare vs last release or some previous commit. |
We don't have quite the performance tests we envisioned, but because of the timeouts and regular monitoring of CI I think we've got something good enough that this can be closed. If anyone's got any brilliant visions for new tests, they can open an new issue. |
As per #97, we could probably use some performance tests so that travis will warn us if there's a huge performance regression we should look at. What the threshold for "failing" should be and how they work can be a topic of discussion here before an implementation is written.
The text was updated successfully, but these errors were encountered: