Skip to content
This repository has been archived by the owner on Aug 25, 2024. It is now read-only.

model: scikit: Add new scikit based models #272

Closed
5 of 6 tasks
pdxjohnny opened this issue Dec 24, 2019 · 0 comments
Closed
5 of 6 tasks

model: scikit: Add new scikit based models #272

pdxjohnny opened this issue Dec 24, 2019 · 0 comments
Labels
enhancement New feature or request kind/ml Issues partaining to machine learning p2 Medium Priority tM Esitmated Time To Complete: Medium

Comments

@pdxjohnny
Copy link
Member

pdxjohnny commented Dec 24, 2019

@sakshamarora1 is working on adding more models to scikit models

Current issue is that any classes with __init__ arguments that don’t have default values are not being added as properties to cls.CONFIG.

Plan

  • Focus on figuring out what models have no parameters that have no default values.
  • Verify that those models work
  • Identify a few models which are failing
  • Get the make_config implemented (Replace args and config methods with CONFIG property #164)
  • Change namedtuple(...) calls which create dffml_config into calls to make_config(...)
    • This requires parsing the docstring to identify which types a scikit parameter should be (this can be done at any time)
MAPPING = {
    "string": str,
    "list of dicts": List[dict],
    # ...
}
  • Make sure we have all the mapping for at least one class so we can start testing this out.

https://github.com/scikit-learn/scikit-learn/blob/bf24c7e3d/sklearn/ensemble/_forest.py#L851-L1013

In the future we will make it so we can dynamically instantiate any scikit model.

This issue is a part of #29

@pdxjohnny pdxjohnny added the enhancement New feature or request label Dec 24, 2019
@pdxjohnny pdxjohnny added this to the 0.3.3 Alpha Release milestone Jan 3, 2020
@pdxjohnny pdxjohnny added kind/ml Issues partaining to machine learning p2 Medium Priority tM Esitmated Time To Complete: Medium labels Jan 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request kind/ml Issues partaining to machine learning p2 Medium Priority tM Esitmated Time To Complete: Medium
Projects
None yet
Development

No branches or pull requests

1 participant