Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DVT-84 #97

Merged
merged 6 commits into from
Dec 29, 2023
Merged

fix: DVT-84 #97

merged 6 commits into from
Dec 29, 2023

Conversation

Muhammed-baban
Copy link

SUMMARY

feat: dvt-navigation

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@omerfbolat
Copy link

a element olursa bir bastığında hep refresh oluyor redux temizleniyor bu a element olmamalı.
React kural olarak react-router-dom router için kullanıyoruz Route ve Link bu kullanmalı.

dvt-layout.tsx "useHistory" bu pathname gelmiyorsa "useLocation" çalışabilir mi dener misin.


const handleNavigation = (url: string) => {
if (location.pathname !== url) {
window.location.href = url;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

window.location.href olmamalı.

@Muhammed-baban Muhammed-baban changed the title DVT-84 feat: DVT-84 Dec 29, 2023
@Muhammed-baban Muhammed-baban changed the title feat: DVT-84 fix: DVT-84 Dec 29, 2023
@omerfbolat omerfbolat merged commit 4a72934 into dev Dec 29, 2023
31 of 32 checks passed
@omerfbolat omerfbolat deleted the DVT-84 branch December 29, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants