Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error during update from 0.25.0 to 0.25.1 #313

Open
aamederen opened this issue May 31, 2017 · 2 comments
Open

Error during update from 0.25.0 to 0.25.1 #313

aamederen opened this issue May 31, 2017 · 2 comments

Comments

@aamederen
Copy link

I have an existing app with pliny 0.25.0. When I run pliny-update I get an error as following:

$ cat Gemfile.lock | grep pliny
    pliny (0.25.0)
$ pliny-update
Updating from 0.25.0 to 0.25.1...
error: unrecognized input


Pliny update applied. Please review the changes staged for
commit, and consider applying the diff in .rej files manually.
You can then remove these files with `git clean -f`.

Nothing has changed in code after running pliny-update, including Gemfile.lock.

@gudmundur
Copy link
Member

gudmundur commented May 31, 2017

Looking at the diff between v0.25.0 and v0.25.1, the only changes were within Pliny itself, not in the template which we apply to your project. The error: unrecognized input line stands out, which I assume happens here, as the patch generated earlier is empty.

I think that the end result you're seeing is what should happen, even though there's an error there. I think there's room for the updater to account for empty patches and indicate that.

Does this feel like a fair assessment of what's happening?

@aamederen
Copy link
Author

Thanks @gudmundur. Seeing a false error confused me. Maybe showing a message indicating that nothing to change in code can be considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants