-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure current unit tests pass on CI under Python 2.7 #23
Comments
My apologies for b8831c7 and thanks for you efforts to repair it. The plan above sounds most resonable to me. |
I have a branch https://github.com/internetarchive/infogami/tree/repair-tests where the Travis CI results match the test results I get locally at this commit Results: https://travis-ci.org/internetarchive/infogami/jobs/573626882 Which is failing on the issue reported at infogami#4 I thought I'd fixed it in #9 , but the 'unused' import I removed is used in that file, so it's not a good fix. To add the suggested |
For now, can we put a # noqa linter directive on the import line so that we can progress beyond that one? |
The |
Can this be closed now? |
yes, Closing as done, Python 2.7 tests are passing. |
Commit b8831c7 removed the existing tests from running on CI, which enabled a parse error to slip into
master
, involving atry
with a missingexcept
block which is fixed by #20After some discussion (amongst archive.org staff and volunteers) we agreed the following:
Therefore we need to upgrade this internetarchive/infogami fork to Python 3 to support Open Library.
To do this safely since this codebase has had had much activity for a long time, we need to have confidence that we are not breaking anything in our fork with current changes.
The text was updated successfully, but these errors were encountered: