Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev instance login to fail if incorrect admin credentials #2050

Closed
mekarpeles opened this issue Apr 15, 2019 · 5 comments
Closed

Fix dev instance login to fail if incorrect admin credentials #2050

mekarpeles opened this issue Apr 15, 2019 · 5 comments
Labels
Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] Module: Docker Issues related to the configuration or use of Docker. [managed] Needs: Lead Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Development Issues related to the developer experience and the dev environment. [managed] Type: Bug Something isn't working. [managed]

Comments

@mekarpeles
Copy link
Member

mekarpeles commented Apr 15, 2019 •
edited by jdlrobson
Loading

If user on dev enters wrong admin email + password and spoofs login, unable to login as admin. The flow should be fixed

Originally posted by @mekarpeles in #1197 (comment)

= Notes from @jdlrobson
A workaround exists while this problem remains in #1197 (comment)
@jdlrobson
Copy link
Collaborator

Where is the workaround for users that have accidentally entered wrong email? I can't find the link an y more :(

@cdrini
Copy link
Collaborator

cdrini commented Apr 23, 2019

#1197 (comment)

@brad2014 brad2014 added Theme: Development Issues related to the developer experience and the dev environment. [managed] Type: Bug Something isn't working. [managed] Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] and removed CH: dev-instance labels May 13, 2019
@xayhewalo xayhewalo added Module: Docker Issues related to the configuration or use of Docker. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] State: Backlogged labels Nov 12, 2019
@mekarpeles mekarpeles added the Lead: @hornc Issues overseen by Charles (Staff: Data Engineering Lead) [managed] label Dec 18, 2019
@hornc hornc removed their assignment Mar 7, 2020
@SaravgiYash
Copy link
Contributor

@mekarpeles any update on this cause I am unable to login as admin even after clearing my cookies

@RayBB
Copy link
Collaborator

RayBB commented May 1, 2021

For anyone who didn't have luck clearing the cookies and restarting the service as mentioned in the workaround. Resetting the database fixed the issue for me. You can find the command here https://github.com/internetarchive/openlibrary/blob/master/docker/README.md

# remove all volumes (i.e. reset all databases); perform WHILE RUNNING
docker-compose stop
docker-compose rm -v

@cdrini cdrini mentioned this issue May 10, 2021
Closed
@hornc hornc removed the Lead: @hornc Issues overseen by Charles (Staff: Data Engineering Lead) [managed] label Sep 10, 2023
@mekarpeles
Copy link
Member Author

This should no longer be an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] Module: Docker Issues related to the configuration or use of Docker. [managed] Needs: Lead Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Development Issues related to the developer experience and the dev environment. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@jdlrobson @hornc @RayBB @mekarpeles @cdrini @brad2014 @xayhewalo @SaravgiYash