Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependancy mockcache is not compatible with Python 3 #3183

Closed
cclauss opened this issue Mar 14, 2020 · 0 comments · Fixed by #3184
Closed

Dependancy mockcache is not compatible with Python 3 #3183

cclauss opened this issue Mar 14, 2020 · 0 comments · Fixed by #3184
Labels
Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Question This issue doesn't require code. A question needs an answer. [managed]

Comments

@cclauss
Copy link
Collaborator

cclauss commented Mar 14, 2020 •
edited
Loading

openlibrary/core/cache.py uses mockcache which can not be installed on Python 3 as discussed at #1687.

python2 -m pytest openlibrary/tests/core/test_ia.py # passes
python3 -m pytest openlibrary/tests/core/test_ia.py # fails

Question

Additional context

Stakeholders
@cclauss cclauss added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Question This issue doesn't require code. A question needs an answer. [managed] labels Mar 14, 2020
@cclauss cclauss mentioned this issue Mar 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Question This issue doesn't require code. A question needs an answer. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pymemcache MockMemcacheClient instead of mockcache on Python 3
2 participants
@mekarpeles @cclauss