Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Plutus minting script doc #2883

Merged
merged 5 commits into from
Oct 31, 2022
Merged

Add Plutus minting script doc #2883

merged 5 commits into from
Oct 31, 2022

Conversation

Jimbo4350
Copy link
Contributor

No description provided.

@Jimbo4350 Jimbo4350 force-pushed the jordan/plutus-minting-docs branch 3 times, most recently from 5c10440 to a12d31f Compare June 30, 2021 09:27
@Jimbo4350 Jimbo4350 force-pushed the jordan/plutus-minting-docs branch 2 times, most recently from b8055c4 to c374b81 Compare September 6, 2021 14:34
catch-21
catch-21 suggested changes Jul 22, 2022
View reviewed changes
doc/reference/plutus/plutus-minting-script-example.md Outdated Show resolved Hide resolved
doc/reference/plutus/plutus-minting-script-example.md Outdated
--mint-script-file "scripts/plutus/scripts/anyone-can-mint.plutus" \
--mint-redeemer-file "scripts/plutus/data/42.redeemer" \
--mint-execution-units "($plutusrequiredspace, $plutusrequiredtime)" \
--tx-out "$dummyaddress+$spendable + 5 2dce00a8d52ccd0c53be5165dd7a7e8e1d08d87f05f8f91047ca5d0b.4D696C6C6172436F696E0A" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth explaining the format used here policyId.assetName or refer to https://github.com/input-output-hk/cardano-documentation/blob/master/content/07-native-tokens/03-getting-started.mdx#understanding-values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^ page not found

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this one: https://github.com/input-output-hk/cardano-documentation/blob/master/content/08-native-tokens/03-getting-started.mdx#understanding-values

LudvikGalois
LudvikGalois reviewed Sep 5, 2022
View reviewed changes
doc/reference/plutus/plutus-minting-script-example.md Outdated

You can find an example redeemer at: `scripts/plutus/data/42.redeemer`

For more information regarding `tx-in-collateral` and `mint-execution-units` see [here](plutus-spending-script-example.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see plutus-spending-script-example.md contains no meaningful information about either those. It does use tx-in-execution-units and explains

$plutusrequiredtime and $plutusrequiredspace - These make up the Plutus script execution budget and are part of the $txfee

but gives no information how to calculate them.

Copy link
Contributor Author

@Jimbo4350 Jimbo4350 Sep 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have the --calculate-plutus-script-cost flag in the build command that will output the script cost. I'll add this to the docs. Outside of this I believe its a guessing game.

doc/reference/plutus/plutus-minting-script-example.md Outdated Show resolved Hide resolved
doc/reference/plutus/plutus-minting-script-example.md Outdated
For more information regarding `tx-in-collateral` and `mint-execution-units` see [here](plutus-spending-script-example.md).

```bash
cardano-cli transaction build-raw \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for preferring build-raw to build here? Is it to make the fees more explicit?

Copy link
Contributor Author

@Jimbo4350 Jimbo4350 Sep 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think build did not exist at the time

@Jimbo4350 Jimbo4350 merged commit 745f069 into master Oct 31, 2022
@iohk-bors iohk-bors bot deleted the jordan/plutus-minting-docs branch October 31, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catch-21 catch-21 catch-21 requested changes

@olgahryniuk olgahryniuk olgahryniuk left review comments

@LudvikGalois LudvikGalois LudvikGalois left review comments

@nc6 nc6 nc6 left review comments

@newhoggy newhoggy newhoggy approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jimbo4350 @newhoggy @nc6 @LudvikGalois @olgahryniuk @catch-21