Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cardano-cli: Add option --stake-address to several subcommands #3404

Merged
merged 3 commits into from
Mar 17, 2023
Merged

cardano-cli: Add option --stake-address to several subcommands #3404

merged 3 commits into from
Mar 17, 2023
+66 −69

Conversation

cblp
Copy link
Contributor

@cblp cblp commented Nov 30, 2021

Fix #2723

@cblp
Copy link
Contributor Author

cblp commented Nov 30, 2021 

Usage: cardano-cli stake-address registration-certificate 
            ( --stake-verification-key STRING
            | --stake-verification-key-file FILE
            | --stake-script-file FILE
            | --stake-address ADDRESS
            )
            --out-file FILE

  Create a stake address registration certificate

Available options:
  --stake-verification-key STRING
                           Stake verification key (Bech32 or hex-encoded).
  --stake-verification-key-file FILE
                           Filepath of the staking verification key.
  --stake-script-file FILE Filepath of the staking script.
  --stake-address ADDRESS  Target stake address (bech32 format).
  --out-file FILE          The output file.
  -h,--help                Show this help text

@disassembler is this what you expected?

@cblp cblp marked this pull request as draft November 30, 2021 15:37
Jimbo4350
Jimbo4350 requested changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

cardano-cli/src/Cardano/CLI/Shelley/Commands.hs Outdated Show resolved Hide resolved
@cblp cblp force-pushed the cblp/stake-address_registration-certificate_--stake-address branch 3 times, most recently from 86df41b to 4dc3033 Compare December 20, 2021 16:15
@cblp cblp marked this pull request as ready for review December 22, 2021 13:16
@cblp cblp requested a review from Jimbo4350 December 22, 2021 13:17
@cblp cblp force-pushed the cblp/stake-address_registration-certificate_--stake-address branch 2 times, most recently from cf2beb3 to 4f9e173 Compare December 23, 2021 15:48
@cblp cblp changed the title cardano-cli: Add option --stake-address to subcommand stake-address registration-certificate cardano-cli: Add option --stake-address to several subcommands Dec 23, 2021
@cblp
Copy link
Contributor Author

cblp commented Dec 23, 2021

@Jimbo4350 does this CLI change require updating documentation or version bump?

@cblp cblp force-pushed the cblp/stake-address_registration-certificate_--stake-address branch 2 times, most recently from 851f2f8 to 93262ff Compare January 21, 2022 13:36
@cblp cblp force-pushed the cblp/stake-address_registration-certificate_--stake-address branch from 93262ff to f7df413 Compare January 27, 2022 15:03
@cblp cblp force-pushed the cblp/stake-address_registration-certificate_--stake-address branch from f7df413 to f217cdb Compare February 11, 2022 15:13
@cblp cblp force-pushed the cblp/stake-address_registration-certificate_--stake-address branch from ffe0d7d to 23184f6 Compare March 23, 2022 17:00
@cblp cblp force-pushed the cblp/stake-address_registration-certificate_--stake-address branch from 23184f6 to 14322b9 Compare March 24, 2022 11:15
@cblp cblp force-pushed the cblp/stake-address_registration-certificate_--stake-address branch from 14322b9 to c88ab2e Compare March 24, 2022 11:56
Jimbo4350
Jimbo4350 approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cardano-cli/src/Cardano/CLI/Shelley/Run/StakeAddress.hs
@@ -216,3 +172,31 @@ runStakeCredentialDeRegistrationCert stakeVerifier (OutputFile oFp) =

deregCertDesc :: TextEnvelopeDescr
deregCertDesc = "Stake Address Deregistration Certificate"


getStakeCredentialFromVerifier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. This is much simpler now.

@cblp cblp force-pushed the cblp/stake-address_registration-certificate_--stake-address branch from c88ab2e to 4f9a472 Compare April 5, 2022 08:49
@cblp cblp force-pushed the cblp/stake-address_registration-certificate_--stake-address branch from 4f9a472 to e09ac77 Compare April 15, 2022 15:48
@cblp cblp force-pushed the cblp/stake-address_registration-certificate_--stake-address branch from e09ac77 to 69de0f9 Compare April 27, 2022 10:00
@cblp cblp force-pushed the cblp/stake-address_registration-certificate_--stake-address branch from 69de0f9 to 0fcbfef Compare May 5, 2022 11:27
@newhoggy
Copy link
Contributor

This affects the following commands:

  • address build
  • stake-address build
  • stake-address registration-certificate
  • stake-address delegation-certificate
  • stake-address deregistration-certificate

@newhoggy newhoggy force-pushed the cblp/stake-address_registration-certificate_--stake-address branch from 0fcbfef to 0bd5b59 Compare February 23, 2023 10:56
@newhoggy newhoggy self-assigned this Feb 23, 2023
@newhoggy newhoggy force-pushed the cblp/stake-address_registration-certificate_--stake-address branch 2 times, most recently from 5eacd9e to 2b2cf63 Compare March 7, 2023 10:49
@newhoggy newhoggy enabled auto-merge March 7, 2023 10:50
@newhoggy newhoggy added this pull request to the merge queue Mar 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2023
cblp and others added 3 commits March 17, 2023 20:03
@cblp @newhoggy
cardano-api: Add getStakeAddressCredential to get creadential from …
11db78f 
…a stake address
@cblp @newhoggy
cardano-cli: Add option --stake-address to some subcommands:
ea1a785 
- address build
- stake-address build
- stake-address registration-certificate
- stake-address deregistration-certificate
- stake-address delegation-certificate

Fix #2723
@newhoggy
Update changelog with new --stake-address option
8f3c77b
@newhoggy newhoggy force-pushed the cblp/stake-address_registration-certificate_--stake-address branch from 2b2cf63 to 8f3c77b Compare March 17, 2023 09:03
@newhoggy newhoggy enabled auto-merge March 17, 2023 09:11
@newhoggy newhoggy added this pull request to the merge queue Mar 17, 2023
Merged via the queue into master with commit 377c0e5 Mar 17, 2023
@iohk-bors iohk-bors bot deleted the cblp/stake-address_registration-certificate_--stake-address branch March 17, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@nc6 nc6 Awaiting requested review from nc6

@newhoggy newhoggy Awaiting requested review from newhoggy

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees

@newhoggy newhoggy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - add option to stake-address registration-certificate to take an address
3 participants
@cblp @newhoggy @Jimbo4350