RTView: MVP #4105
Merged
RTView: MVP #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisshevchenko
force-pushed
the
issue-4096-rtview-mvp
branch
from
3ad471d
to
c4912e4
Compare
denisshevchenko
force-pushed
the
issue-4096-rtview-mvp
branch
4 times, most recently
from
eda3ce7
to
72db433
Compare
denisshevchenko
requested review from
Jimbo4350,
newhoggy,
jutaro,
dcoutts,
erikd and
JaredCorduan
as code owners
denisshevchenko
force-pushed
the
issue-4096-rtview-mvp
branch
from
72db433
to
f8503de
Compare
iohk-bors bot
added a commit
that referenced
this pull request
Jul 8, 2022
4105: RTView: MVP r=deepfire a=denisshevchenko Closes #4096 MVP for RTView: it's not ready for production yet, but ready for testing by SPOs. Co-authored-by: Denis Shevchenko <[email protected]>
|
bors r- |
|
Canceled. |
Jimbo4350
requested changes
Jul 8, 2022
|
|
||
| -- | This information is taken from 'BasicInfoShelleyBased'. It is required for | ||
| -- 'cardano-tracer' service (particularly, for RTView). | ||
| data NodeStartupInfo = NodeStartupInfo { |
There was a problem hiding this comment.
If it is taken from BasicInfoShelleyBased why are we essentially duplicating the type?
There was a problem hiding this comment.
NodeStartupInfotakes not all fields fromBasicInfoShelleyBased.NodeStartupInfocan (and I'm sure, will) contain additional data in the future, not only fromBasicInfoShelleyBased.
Jimbo4350
approved these changes
Jul 8, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 8, 2022
4105: RTView: MVP r=denisshevchenko a=denisshevchenko Closes #4096 MVP for RTView: it's not ready for production yet, but ready for testing by SPOs. Co-authored-by: Denis Shevchenko <[email protected]>
|
Timed out. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4096
MVP for RTView: it's not ready for production yet, but ready for testing by SPOs.