-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tx-generator: fix a bug #4239
Merged
Merged
tx-generator: fix a bug #4239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of 43200 TXs of 2 outputs 43200 TXs of 43200 outputs each were generated.
MarcFontaine
requested review from
Jimbo4350,
newhoggy,
deepfire,
denisshevchenko,
jutaro,
mgmeier,
fmaste and
cleverca22
as code owners
July 28, 2022 11:55
mgmeier
approved these changes
Jul 29, 2022
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 29, 2022
4239: tx-generator: fix a bug r=MarcFontaine a=MarcFontaine The bug was introduced in : #3815. The number of total output transactions of the tx-generator was used for the number of outputs of a single transaction. It was not found because the tests were only run for Plutus workloads and the bug was in a non-Plutus code-branch. Co-authored-by: MarcFontaine <[email protected]>
Build failed: |
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 29, 2022
4239: tx-generator: fix a bug r=MarcFontaine a=MarcFontaine The bug was introduced in : #3815. The number of total output transactions of the tx-generator was used for the number of outputs of a single transaction. It was not found because the tests were only run for Plutus workloads and the bug was in a non-Plutus code-branch. Co-authored-by: MarcFontaine <[email protected]>
bors retry |
🔒 Permission denied Existing reviewers: click here to make mgmeier a reviewer |
Build failed: |
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was introduced in : #3815.
The number of total output transactions of the tx-generator was used for the number of outputs of a single transaction.
It was not found because the tests were only run for Plutus workloads and the bug was in a non-Plutus code-branch.