Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx-generator: fix a bug #4239

Merged
merged 2 commits into from
Jul 29, 2022
Merged

tx-generator: fix a bug #4239

merged 2 commits into from
Jul 29, 2022

Conversation

MarcFontaine
Copy link
Contributor

The bug was introduced in : #3815.
The number of total output transactions of the tx-generator was used for the number of outputs of a single transaction.
It was not found because the tests were only run for Plutus workloads and the bug was in a non-Plutus code-branch.

Instead of 43200 TXs of 2 outputs 43200 TXs of 43200 outputs each were generated.
@MarcFontaine MarcFontaine self-assigned this Jul 28, 2022
@MarcFontaine MarcFontaine added bug Something isn't working benchmark labels Jul 28, 2022
@MarcFontaine MarcFontaine marked this pull request as ready for review July 28, 2022 11:55
@MarcFontaine
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 29, 2022
4239: tx-generator: fix a bug r=MarcFontaine a=MarcFontaine

The bug was introduced in :  #3815.
The number of total output transactions of the tx-generator was used for the number of outputs of a single transaction.
It was not found because the tests were only run for Plutus workloads and the bug was in a non-Plutus code-branch.

Co-authored-by: MarcFontaine <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 29, 2022

Build failed:

@MarcFontaine
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 29, 2022
4239: tx-generator: fix a bug r=MarcFontaine a=MarcFontaine

The bug was introduced in :  #3815.
The number of total output transactions of the tx-generator was used for the number of outputs of a single transaction.
It was not found because the tests were only run for Plutus workloads and the bug was in a non-Plutus code-branch.

Co-authored-by: MarcFontaine <[email protected]>
@mgmeier
Copy link
Contributor

mgmeier commented Jul 29, 2022

bors retry

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 29, 2022

🔒 Permission denied

Existing reviewers: click here to make mgmeier a reviewer

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 29, 2022

Build failed:

@MarcFontaine
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 29, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit aed8e71 into master Jul 29, 2022
@iohk-bors iohk-bors bot deleted the mafo/tx-generator-submit-bug branch July 29, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants