Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tx-mempool command to CLI #4276

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Conversation

LudvikGalois
Copy link
Contributor

@LudvikGalois LudvikGalois commented Aug 5, 2022

This adds 3 commands

cardano-cli query tx-mempool info which prints stats for the transaction mempool for the node
cardano-cli query tx-mempool next-tx which returns the ID of the next transaction to be processed
cardano-cli query tx-mempool tx-exists <txid> which tells you whether or not a transaction is in the mempool

Closes #3774
Closes #4459

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍 A few comments

cardano-cli/src/Cardano/CLI/Shelley/Commands.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Commands.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Parsers.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Run/Query.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Run/Query.hs Outdated Show resolved Hide resolved
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely minor changes

cardano-api/src/Cardano/Api/IPC.hs Outdated Show resolved Hide resolved
cardano-cli/ChangeLog.md Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Parsers.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Run/Query.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Parsers.hs Outdated Show resolved Hide resolved
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, get QA to sign off.

@LudvikGalois
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 24, 2022
4276: Add tx-mempool command to CLI r=LudvikGalois a=LudvikGalois

This adds 3 commands

`cardano-cli query tx-mempool info` which prints stats for the transaction mempool for the node
`cardano-cli query tx-mempool next-tx` which returns the ID of the next transaction to be processed
`cardano-cli query tx-mempool tx-exists <txid>` which tells you whether or not a transaction is in the mempool

Closes #3774
Closes #4459

Co-authored-by: Robert 'Probie' Offner <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 24, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from input-output-hk/docs-access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@LudvikGalois
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 24, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 2634432 into IntersectMBO:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: tx-mempool CLI commands [FR] - Expose Tx Mempool Monitoring Mini Protocol via Cli
4 participants