Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workbench: changes needed to support a new backend #4457

Merged
merged 1 commit into from
Sep 22, 2022
Merged

workbench: changes needed to support a new backend #4457

merged 1 commit into from
Sep 22, 2022

Conversation

fmaste
Copy link
Contributor

@fmaste fmaste commented Sep 20, 2022 •
edited
Loading

  • Reuse current directory structures
  • Add "shutdown_on_slot_synced" and "shutdown_on_block_synced" to node-specs.json
  • Environment variable WB_SHELL_PROFILE_DIR to the profile directory inside the shell

@fmaste fmaste marked this pull request as ready for review September 20, 2022 22:39
deepfire
deepfire approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmaste, looks great, thank you!

Can I ask to ensure that chainsync-early-byron works?

@fmaste
Copy link
Contributor Author

fmaste commented Sep 22, 2022

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 22, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 002e0ca into master Sep 22, 2022
@iohk-bors iohk-bors bot deleted the bench-refactoring branch September 22, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire approved these changes

@mgmeier mgmeier Awaiting requested review from mgmeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmaste @deepfire