GHC 9.2.4 preparations #4504
Merged
GHC 9.2.4 preparations #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
node/ghc-9.2.4-preparations
branch
6 times, most recently
from
5d90c54
to
c22f523
Compare
newhoggy
requested review from
Jimbo4350,
deepfire,
denisshevchenko,
jutaro,
mgmeier,
MarcFontaine,
fmaste,
cleverca22,
dcoutts,
erikd,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
Jimbo4350
reviewed
Oct 4, 2022
| @@ -381,7 +381,6 @@ newtype CurrentEpochState era = CurrentEpochState (Shelley.EpochState (ShelleyLe | |||
|
|
|||
| decodeCurrentEpochState | |||
| :: forall era. Ledger.Era (ShelleyLedgerEra era) | |||
| => Share (Core.TxOut (ShelleyLedgerEra era)) ~ Interns (Shelley.Credential 'Shelley.Staking (Ledger.Crypto (ShelleyLedgerEra era))) | |||
There was a problem hiding this comment.
Interesting, what prompted this change?
There was a problem hiding this comment.
ghc-9.2.4 flagged that as an unused constrained and given that it compiles with ghc-8.10.7 flagging it as unused is correct.
Jimbo4350
approved these changes
Oct 4, 2022
| @@ -123,7 +123,6 @@ library | |||
| , async-extras | |||
| , bimap | |||
| , blaze-html | |||
| , blaze-markup | |||
|
I've verified the Windows CI build failures are unrelated to this PR: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 4, 2022
4504: GHC 9.2.4 preparations r=newhoggy a=newhoggy These changes move the code towards `ghc-9.2.4` compatibility. Co-authored-by: John Ky <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from MarcFontaine, cleverca22, deepfire, denisshevchenko, fmaste, jutaro, and/or mgmeier.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
erikd
approved these changes
Oct 4, 2022
mgmeier
approved these changes
Oct 5, 2022
newhoggy
force-pushed
the
node/ghc-9.2.4-preparations
branch
from
c22f523
to
df35276
Compare
|
Squashed commits as requested. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 5, 2022
4504: GHC 9.2.4 preparations r=newhoggy a=newhoggy These changes move the code towards `ghc-9.2.4` compatibility. Co-authored-by: John Ky <[email protected]>
|
Timed out. |
newhoggy
force-pushed
the
node/ghc-9.2.4-preparations
branch
from
df35276
to
969bc78
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 11, 2022
4504: GHC 9.2.4 preparations r=newhoggy a=newhoggy These changes move the code towards `ghc-9.2.4` compatibility. Co-authored-by: John Ky <[email protected]>
|
Build failed: |
* Type application symbol @ should not be followed with space * Operators must be separated by spaces * Bang pattern symbol ! must not be followed by space * Use type applications to disambguate use of show * Qualified import for Data.List to avoid ambiguity * Don't hide import of option. Use qualified import of Options.Applicative instead. * Use of $ operator should be followed by whitespace because $( is extrictly for TemplateHaskell * Add missing type signature of top level function * Qualified import of Data.Text.Lazy
newhoggy
force-pushed
the
node/ghc-9.2.4-preparations
branch
from
969bc78
to
9062cc3
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 12, 2022
4504: GHC 9.2.4 preparations r=newhoggy a=newhoggy These changes move the code towards `ghc-9.2.4` compatibility. Co-authored-by: John Ky <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from deepfire and/or denisshevchenko.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
deepfire
approved these changes
Oct 12, 2022
|
bors r+ |
denisshevchenko
approved these changes
Oct 12, 2022
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes move the code towards
ghc-9.2.4compatibility.