Bump CHaP and remove ekg-json s-r-p
#4519
Merged
+39
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
requested review from
deepfire,
mgmeier,
fmaste,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
michaelpj
force-pushed
the
mpj/ekg-json
branch
2 times, most recently
from
16aa00f
to
4977680
Compare
|
Got rid of the one for |
|
@newhoggy maybe you could take a look? |
newhoggy
approved these changes
Oct 13, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 13, 2022
4519: Bump CHaP and remove `ekg-json` s-r-p r=michaelpj a=michaelpj I had to fix a few things, especially adding some constraints that should be in upstream packages. We can fix those with revisions once we get those working. Co-authored-by: Michael Peyton Jones <[email protected]>
|
Timed out. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 13, 2022
4519: Bump CHaP and remove `ekg-json` s-r-p r=michaelpj a=michaelpj I had to fix a few things, especially adding some constraints that should be in upstream packages. We can fix those with revisions once we get those working. Co-authored-by: Michael Peyton Jones <[email protected]>
|
Build failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 13, 2022
4519: Bump CHaP and remove `ekg-json` s-r-p r=michaelpj a=michaelpj I had to fix a few things, especially adding some constraints that should be in upstream packages. We can fix those with revisions once we get those working. Co-authored-by: Michael Peyton Jones <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from deepfire, denisshevchenko, fmaste, jutaro, and/or mgmeier.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
Oh, apparently John is not good enough despite being listed as a codeowner? I'm confused. |
|
Um, maybe @deepfire ? |
michaelpj
force-pushed
the
mpj/ekg-json
branch
from
4977680
to
449e556
Compare
|
bors r+ |
disassembler
approved these changes
Oct 17, 2022
iohk-bors bot
added a commit
that referenced
this pull request
Oct 17, 2022
4519: Bump CHaP and remove `ekg-json` s-r-p r=disassembler a=michaelpj I had to fix a few things, especially adding some constraints that should be in upstream packages. We can fix those with revisions once we get those working. Co-authored-by: Michael Peyton Jones <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from deepfire, denisshevchenko, fmaste, jutaro, and/or mgmeier.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
deepfire
approved these changes
Oct 17, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to fix a few things, especially adding some constraints that should be in upstream packages. We can fix those with revisions once we get those working.