Bump CHaP again, account for re-release of existing packages #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
requested review from
deepfire,
mgmeier,
fmaste,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
|
@disassembler hydra succeeded |
LudvikGalois
approved these changes
Oct 19, 2022
|
Once I'd cleaned out some stale files in my |
Jimbo4350
approved these changes
Oct 19, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 19, 2022
4542: Bump CHaP again, account for re-release of existing packages r=Jimbo4350 a=michaelpj The packages in CHaP have been re-released to line up with 1.35.3. Unfortunately, these are not compatible with node master. Hence I've had to restore some of the `source-repository-package` stanzas from previously. We will aim to get rid of these as quickly as possible, although this may require doing some additional releases. This is a pretty major DevX loss, since we're back to `source-repository-package`s, but without this things are actually broken again :( Co-authored-by: Michael Peyton Jones <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from deepfire, fmaste, and/or mgmeier.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
deepfire
approved these changes
Oct 19, 2022
|
bors r+ |
|
Build succeeded: |
This was referenced Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packages in CHaP have been re-released to line up with 1.35.3. Unfortunately, these are not compatible with node master. Hence I've had to restore some of the
source-repository-packagestanzas from previously. We will aim to get rid of these as quickly as possible, although this may require doing some additional releases.This is a pretty major DevX loss, since we're back to
source-repository-packages, but without this things are actually broken again :(