Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing trace-forward messages #4581

Merged
merged 9 commits into from
Nov 10, 2022
Merged

Conversation

jutaro
Copy link
Contributor

@jutaro jutaro commented Oct 28, 2022

Fix the bug and add a test case.

@jutaro jutaro self-assigned this Oct 28, 2022
@jutaro jutaro requested a review from deepfire October 28, 2022 15:08
@jutaro jutaro linked an issue Oct 28, 2022 that may be closed by this pull request
@jutaro jutaro force-pushed the jutaro/startLeadershipCheck branch from 9a412f2 to 0f1eb47 Compare November 1, 2022 12:22
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jutaro squash the commit history please. There are some unnecessarily small commits.

@deepfire
Copy link
Contributor

deepfire commented Nov 1, 2022

@Jimbo4350, I've been on it already : -)

@deepfire deepfire requested a review from coot as a code owner November 3, 2022 11:15
@deepfire deepfire force-pushed the jutaro/startLeadershipCheck branch 4 times, most recently from f8cfde4 to a1ccad0 Compare November 7, 2022 13:51
@deepfire
Copy link
Contributor

deepfire commented Nov 8, 2022

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 8, 2022
4581: Fix missing trace-forward messages r=deepfire a=jutaro

Fix the bug and add a test case.

Co-authored-by: Yupanqui <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
Co-authored-by: Hamish Mackenzie <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 9, 2022

Build failed:

@Jimbo4350 Jimbo4350 self-requested a review November 9, 2022 13:37
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not appreciate that I approved this PR on the condition that the commits were squashed but there are now 24 commits on this PR and you are trying to merge it @deepfire. Please squash the commits.

@deepfire deepfire force-pushed the jutaro/startLeadershipCheck branch 5 times, most recently from 8a4ae19 to 4af0cfa Compare November 9, 2022 18:11
@deepfire deepfire force-pushed the jutaro/startLeadershipCheck branch 4 times, most recently from 5acca69 to 00cdd72 Compare November 10, 2022 12:06
@Jimbo4350 Jimbo4350 self-requested a review November 10, 2022 12:47
@deepfire
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 10, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit b8414eb into master Nov 10, 2022
@iohk-bors iohk-bors bot deleted the jutaro/startLeadershipCheck branch November 10, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trace-forward: Random dropping of messages
4 participants