-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing trace-forward messages #4581
Conversation
9a412f2
to
0f1eb47
Compare
7734f18
to
7e2ac1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jutaro squash the commit history please. There are some unnecessarily small commits.
7e2ac1d
to
908bed4
Compare
@Jimbo4350, I've been on it already : -) |
f8cfde4
to
a1ccad0
Compare
bors r+ |
4581: Fix missing trace-forward messages r=deepfire a=jutaro Fix the bug and add a test case. Co-authored-by: Yupanqui <[email protected]> Co-authored-by: Kosyrev Serge <[email protected]> Co-authored-by: Hamish Mackenzie <[email protected]>
Build failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not appreciate that I approved this PR on the condition that the commits were squashed but there are now 24 commits on this PR and you are trying to merge it @deepfire. Please squash the commits.
8a4ae19
to
4af0cfa
Compare
5acca69
to
00cdd72
Compare
00cdd72
to
3bf6265
Compare
bors r+ |
Build succeeded: |
Fix the bug and add a test case.