Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder module hierarchy #4595

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Reorder module hierarchy #4595

merged 1 commit into from
Nov 3, 2022

Conversation

MarcFontaine
Copy link
Contributor

No description provided.

@MarcFontaine MarcFontaine self-assigned this Nov 2, 2022
@MarcFontaine
Copy link
Contributor Author

follow up of #4558

@MarcFontaine MarcFontaine force-pushed the mafo/4558-directory-structure-cont branch from cb4d7e8 to d57b028 Compare November 2, 2022 15:04
@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Nov 2, 2022 •
edited
Loading

👍 Nice. Now lets move:

  • cardano-testnet/src/Spec/* -> cardano-testnet/test/Test (rename Spec to Test)
  • cardano-testnet/test -> cardano-testnet/util and we can probably rename cardano-testnet/src/Test/Util.hs to cardano-testnet/src/Test/Ignore.hs for now

I'll approve after this.

@MarcFontaine MarcFontaine force-pushed the mafo/4558-directory-structure-cont branch 2 times, most recently from 46a07a8 to 2d5a4f0 Compare November 2, 2022 17:13
@MarcFontaine MarcFontaine changed the title Move modules from 'test' to 'src' Reorder module hierarchy Nov 2, 2022
@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Nov 2, 2022 •
edited
Loading

👍 I just noticed cardano-testnet/src/Testnet/Properties/Cli. That should also be put in the cardano-testnet/test/Test/Cli/ dir

@MarcFontaine
Copy link
Contributor Author

+1 I just noticed cardano-testnet/src/Testnet/Properties/Cli. That should also be put in the cardano-testnet/test/Test/Cli/ dir

There used to be two different KesPeriodInfo.hs in the hierarchy (One of them importing the other)..I renamed one of them to Test.Misc.

@MarcFontaine MarcFontaine force-pushed the mafo/4558-directory-structure-cont branch from 2d5a4f0 to 44aef75 Compare November 3, 2022 12:41
Jimbo4350
Jimbo4350 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We will need to think of a better name than Misc but the hope is as we add more properties this will naturally crystallize out.

@Jimbo4350
Copy link
Contributor

bors r+

1 similar comment
@MarcFontaine
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 3, 2022

Already running a review

iohk-bors bot added a commit that referenced this pull request Nov 3, 2022
@iohk-bors @MarcFontaine
Merge #4595
240e64a 
4595: Reorder module hierarchy r=Jimbo4350 a=MarcFontaine



Co-authored-by: MarcFontaine <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 3, 2022

Build failed:

@MarcFontaine
Copy link
Contributor Author

bors r+

@MarcFontaine MarcFontaine force-pushed the mafo/4558-directory-structure-cont branch from 44aef75 to a43a82d Compare November 3, 2022 16:59
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 3, 2022

Canceled.

@MarcFontaine
Copy link
Contributor Author

bors r+

@Jimbo4350 Jimbo4350 self-requested a review November 3, 2022 17:00
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 3, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 590d491 into master Nov 3, 2022
@iohk-bors iohk-bors bot deleted the mafo/4558-directory-structure-cont branch November 3, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees

@MarcFontaine MarcFontaine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcFontaine @Jimbo4350