Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tulia task that run system tests on PRs #4705

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented Dec 10, 2022

No description provided.

@jbgi jbgi force-pushed the cardano-node-tests branch 4 times, most recently from 6074040 to 675b632 Compare December 14, 2022 15:16
@jbgi jbgi changed the title [WIP] Run QA tests Tullia hook for running some QA tests on PRs Dec 14, 2022
@jbgi jbgi marked this pull request as ready for review December 14, 2022 15:43
@jbgi jbgi requested a review from dermetfan December 14, 2022 15:44
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which QA tests? There needs to be some documentation around this to understand which tests are run.

@jbgi
Copy link
Contributor Author

jbgi commented Dec 14, 2022

@Jimbo4350 with this PR no tests will be run. It's a first step to be able to later plug-in some tests into the cicero tasks DAG.

The actual tests list is being work-on by QA team. @mkoura or @dorin100 might be more explicit about what QA team want to run on each PR.

@dorin100
Copy link

Which QA tests? There needs to be some documentation around this to understand which tests are run.

I will work this week on a short documentation for these tests/pipelines.

@mkoura
Copy link
Contributor

mkoura commented Jan 18, 2023

I'm not sure what setup is done by tullia. For QA tests you can run smtg like

NODE_REV=ee4cfdd0001fb7d211cdcabe84d3e532d3f6e7ad ENABLE_P2P=1 UPDATE_PV8=1 MAKE_TARGET=testpr ./.github/regression.sh

from cardano-node-tests repo and it will launch tests in nix shell with correct environment. The script prepares the environment and launches make testpr.

@dermetfan dermetfan marked this pull request as draft January 27, 2023 09:58
@jbgi jbgi force-pushed the cardano-node-tests branch 6 times, most recently from 927645f to 897576e Compare February 24, 2023 17:56
@jbgi jbgi force-pushed the cardano-node-tests branch 4 times, most recently from 9ce343c to a85d33a Compare February 24, 2023 19:51
@jbgi jbgi marked this pull request as ready for review February 24, 2023 20:06
@jbgi jbgi force-pushed the cardano-node-tests branch 2 times, most recently from 1ad4cc9 to c142c99 Compare February 28, 2023 10:41
@jbgi jbgi changed the title Tullia hook for running some QA tests on PRs Add tulia task that run system tests. Make it bors mandatory. Feb 28, 2023
@jbgi jbgi force-pushed the cardano-node-tests branch 2 times, most recently from a7237b9 to f15de5c Compare March 6, 2023 10:44
@jbgi jbgi changed the title Add tulia task that run system tests. Make it bors mandatory. Add tulia task that run system tests on PRs Mar 6, 2023
@jbgi jbgi force-pushed the cardano-node-tests branch 2 times, most recently from 06a3386 to 9cc6ca1 Compare March 6, 2023 10:50
@Jimbo4350 Jimbo4350 requested review from Jimbo4350 and removed request for LudvikGalois March 6, 2023 16:36
@jbgi jbgi added this pull request to the merge queue Mar 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2023
@jbgi jbgi enabled auto-merge March 10, 2023 14:55
auto-merge was automatically disabled March 12, 2023 12:28

Merge queue setting changed

@jbgi jbgi enabled auto-merge March 13, 2023 11:04
@jbgi jbgi added this pull request to the merge queue Mar 13, 2023
Merged via the queue into master with commit 5871eab Mar 13, 2023
@iohk-bors iohk-bors bot deleted the cardano-node-tests branch March 13, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants