-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned cabal files #4710
Merged
Merged
Cleaned cabal files #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coot
commented
Dec 13, 2022
•
edited by newhoggy
Loading
edited by newhoggy
- Updated cabal files
- Cleaned cabal files
- Update copyright
- Consistent indents in cabal files
- Consistent license-files declarations in cabal files
- Update all cabal files to version 3.0
- Add project-config to all cabal files
coot
requested review from
deepfire,
jutaro,
mgmeier,
fmaste,
cleverca22 and
dcoutts
as code owners
December 13, 2022 08:29
coot
requested review from
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
December 13, 2022 08:29
deepfire
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @coot !
Jimbo4350
previously requested changes
Dec 13, 2022
common project-config | ||
build-depends: base >= 4.14 && < 4.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
newhoggy
reviewed
Dec 13, 2022
Do we know if all of our projects have been upgraded to use If so we should stick a lower bound on that package everywhere. |
coot
force-pushed
the
coot/cabal-files
branch
from
December 14, 2022 16:16
bd83d47
to
3785d85
Compare
Some cabal files were missing license field, other's were missing either the LICENSE file or the NOTICE.
The `{}` syntax is rather ugly, let's merge the `base` common stanza into `project-config`.
newhoggy
force-pushed
the
coot/cabal-files
branch
from
December 30, 2022 03:54
3785d85
to
6fbcdbc
Compare
newhoggy
approved these changes
Dec 30, 2022
newhoggy
force-pushed
the
coot/cabal-files
branch
from
December 30, 2022 04:40
6fbcdbc
to
a062325
Compare
newhoggy
force-pushed
the
coot/cabal-files
branch
from
December 30, 2022 07:08
0ce7565
to
97d3d2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.