Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate two fields of CardanoTestnetOptions #4806

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Consolidate two fields of CardanoTestnetOptions #4806

merged 1 commit into from
Jan 19, 2023

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jan 18, 2023 •
edited
Loading

  • Consolidate cardanoBftNodeOptions and cardanoNumPoolNodes records of CardanoTestnetOptions
  • Implement testnetMinimumConfigurationRequirements

@Jimbo4350 Jimbo4350 force-pushed the jordan/consolidate-cardano-testnet-options branch 6 times, most recently from 0c10c7d to 0793160 Compare January 18, 2023 20:18
@Jimbo4350 Jimbo4350 marked this pull request as ready for review January 18, 2023 20:24
@Jimbo4350 Jimbo4350 force-pushed the jordan/consolidate-cardano-testnet-options branch from 0793160 to 4edc2a9 Compare January 18, 2023 20:24
@Jimbo4350 Jimbo4350 changed the title Consolidate CardanoTestnetOptions Consolidate two fields of CardanoTestnetOptions Jan 18, 2023
@Jimbo4350 Jimbo4350 force-pushed the jordan/consolidate-cardano-testnet-options branch from 4edc2a9 to 0d63445 Compare January 19, 2023 13:52
@Jimbo4350
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 19, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit ec3c137 into master Jan 19, 2023
@iohk-bors iohk-bors bot deleted the jordan/consolidate-cardano-testnet-options branch January 19, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jimbo4350 @newhoggy