New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose SerialiseAsRawBytesError in Cardano.Api #5085

Merged

newhoggy merged 1 commit into master from ch1bo/expose-serialise-as-raw-bytes-error

Apr 15, 2023

Contributor

ch1bo commented Apr 12, 2023 •

edited

Loading

The function deserialiseFromRawBytes was changed from Maybe to Either SerialiseAsRawBytesError, but the error type was not exposed in the Cardano.API.


          Expose SerialiseAsRawBytesError in Cardano.Api

f4dd47a

The function deserialiseFromRawBytes was changed from Maybe to Either
SerialiseAsRawBytesError, but the error type was not exposed in the
Cardano.API.

ch1bo requested review from dcoutts, Jimbo4350, erikd, newhoggy, JaredCorduan and CarlosLopezDeLara as code owners

April 12, 2023 10:33

ch1bo added a commit to cardano-scaling/hydra that referenced this pull request


          Fix / update UsingRawBytesHex class/instances

475b137

This should be rather taken from upstream. Created two PRs to avoid
workarounds: IntersectMBO/cardano-node#5085
and IntersectMBO/cardano-node#5086

Contributor Author

ch1bo commented Apr 13, 2023

This is even more important when defining SerialiseAsRawBytes instances. Without the data constructor, instances cannot create the SerialiseAsRawBytesError and will be partial by definition.

ch1bo added a commit to cardano-scaling/hydra that referenced this pull request


          Fix compilation of several Hydra modules

b5dff26

Some instances are incomplete as it is missing the
SerialiseAsRawBytesError from cardano-api to produce the proper Left
values. See IntersectMBO/cardano-node#5085

ch1bo added a commit to cardano-scaling/hydra that referenced this pull request


          Fix compilation of several Hydra modules

e2fdd53

Some instances are incomplete as it is missing the
SerialiseAsRawBytesError from cardano-api to produce the proper Left
values. See IntersectMBO/cardano-node#5085

ch1bo added a commit to cardano-scaling/hydra that referenced this pull request


          Fix / update UsingRawBytesHex class/instances

6aec931

This should be rather taken from upstream. Created two PRs to avoid
workarounds: IntersectMBO/cardano-node#5085
and IntersectMBO/cardano-node#5086

ch1bo added a commit to cardano-scaling/hydra that referenced this pull request


          Fix compilation of several Hydra modules

44ae4c7

Some instances are incomplete as it is missing the
SerialiseAsRawBytesError from cardano-api to produce the proper Left
values. See IntersectMBO/cardano-node#5085

newhoggy enabled auto-merge

April 15, 2023 03:34

newhoggy approved these changes

View reviewed changes

newhoggy added this pull request to the merge queue

Merged via the queue into master with commit 0b8893d

iohk-bors bot deleted the ch1bo/expose-serialise-as-raw-bytes-error branch

April 15, 2023 04:07

ch1bo added a commit to cardano-scaling/hydra that referenced this pull request


          Fix compilation of several Hydra modules

1bbc315

Some instances are incomplete as it is missing the
SerialiseAsRawBytesError from cardano-api to produce the proper Left
values. See IntersectMBO/cardano-node#5085

ch1bo added a commit to cardano-scaling/hydra that referenced this pull request


          Fix compilation of several Hydra modules

8914cf4

Some instances are incomplete as it is missing the
SerialiseAsRawBytesError from cardano-api to produce the proper Left
values. See IntersectMBO/cardano-node#5085

ch1bo added a commit to cardano-scaling/hydra that referenced this pull request


          Fix / update UsingRawBytesHex class/instances

fedb6e6

This should be rather taken from upstream. Created two PRs to avoid
workarounds: IntersectMBO/cardano-node#5085
and IntersectMBO/cardano-node#5086

ch1bo added a commit to cardano-scaling/hydra that referenced this pull request


          Fix compilation of several Hydra modules

a5c95d2

Some instances are incomplete as it is missing the
SerialiseAsRawBytesError from cardano-api to produce the proper Left
values. See IntersectMBO/cardano-node#5085

ch1bo added a commit to cardano-scaling/hydra that referenced this pull request


          Fix / update UsingRawBytesHex class/instances

7b36a5a

This should be rather taken from upstream. Created two PRs to avoid
workarounds: IntersectMBO/cardano-node#5085
and IntersectMBO/cardano-node#5086

ch1bo added a commit to cardano-scaling/hydra that referenced this pull request


          Fix compilation of several Hydra modules

586fe95

Some instances are incomplete as it is missing the
SerialiseAsRawBytesError from cardano-api to produce the proper Left
values. See IntersectMBO/cardano-node#5085

ch1bo added a commit to cardano-scaling/hydra that referenced this pull request


          Fix / update UsingRawBytesHex class/instances

a8f71f0

This should be rather taken from upstream. Created two PRs to avoid
workarounds: IntersectMBO/cardano-node#5085
and IntersectMBO/cardano-node#5086

ch1bo added a commit to cardano-scaling/hydra that referenced this pull request


          Fix compilation of several Hydra modules

369a818

Some instances are incomplete as it is missing the
SerialiseAsRawBytesError from cardano-api to produce the proper Left
values. See IntersectMBO/cardano-node#5085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

newhoggy newhoggy approved these changes

dcoutts Awaiting requested review from dcoutts

Jimbo4350 Awaiting requested review from Jimbo4350

erikd Awaiting requested review from erikd

JaredCorduan Awaiting requested review from JaredCorduan

CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Labels

None yet