Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto init with customizing the default labels sets empty objects #1461

Closed
mattfelten opened this issue Aug 13, 2020 · 1 comment · Fixed by #1473
Closed

auto init with customizing the default labels sets empty objects #1461

mattfelten opened this issue Aug 13, 2020 · 1 comment · Fixed by #1473
Labels
bug Something isn't working released This issue/pull request has been released.

Comments

@mattfelten
Copy link

mattfelten commented Aug 13, 2020

Describe the bug

I'm testing auto on a project that already has GitHub labels set up using lerna-changelog and not interested in changing them at the moment so wanted to rename some of the defaults to match the naming we're already using. I went through the interactive tool and when it finished, my labels array in package.json doesn't have any of my changes.

I've tried it twice.

"auto": {
    "plugins": [
      "npm",
      "all-contributors",
      "first-time-contributor"
    ],
    "onlyPublishWithReleaseLabel": true,
    "labels": [
      {
        "overwrite": true
      },
      {
        "overwrite": true
      },
      {
        "overwrite": true
      },
      {
        "overwrite": true
      },
      {
        "overwrite": true
      },
      {
        "overwrite": true
      },
      {
        "overwrite": true
      },
      {
        "overwrite": true
      },
      {
        "overwrite": true
      },
      {
        "overwrite": true
      }
    ]
  }

To Reproduce

Run npx auto init, set whatever options. When asked Would you like to use customize the default labels?, hit y. Customize names and descriptions of some labels. Finish successfully. See package.json not have info set.

Expected behavior

I expected the label objects to have the values I put into the CLI editor

Environment information:

$ npx auto info
⚠  warning   Could not find plugin: all-contributors
⚠  warning   Could not find plugin: first-time-contributor
✖  error     Found configuration errors:

"labels.0.name"

Expected "string" but got: undefined

"labels.1.name"

Expected "string" but got: undefined

"labels.2.name"

Expected "string" but got: undefined

"labels.3.name"

Expected "string" but got: undefined

"labels.4.name"

Expected "string" but got: undefined

"labels.5.name"

Expected "string" but got: undefined

"labels.6.name"

Expected "string" but got: undefined

"labels.7.name"

Expected "string" but got: undefined

"labels.8.name"

Expected "string" but got: undefined

"labels.9.name"

Expected "string" but got: undefined
 

⚠  warning   These errors are for the fully loaded configuration (this is why some paths might seem off).

Additional context

@mattfelten mattfelten added the bug Something isn't working label Aug 13, 2020
@adierkens
Copy link
Collaborator

🚀 Issue was released in v9.50.9 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants