Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect Updated PR Titles #1082

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Respect Updated PR Titles #1082

merged 2 commits into from
Mar 27, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 27, 2020

What Changed

Mainly this line. We will not override the title found in the git history with the current PR Title on Github.

The rest of the changes are from formatting the whole repo to Prettier 2.0.

Why

closes #1081

Todo:

  • Add tests
📦 Published PR as canary version: under canary scope @[email protected]

✨ Test out this PR locally via:

npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
# or 
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Mar 27, 2020
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #1082 into master will increase coverage by 0.08%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
+ Coverage   81.41%   81.49%   +0.08%     
==========================================
  Files          51       51              
  Lines        3622     3627       +5     
  Branches      726      727       +1     
==========================================
+ Hits         2949     2956       +7     
+ Misses        498      497       -1     
+ Partials      175      174       -1
Impacted Files Coverage Δ
plugins/released/src/index.ts 88.23% <ø> (ø) ⬆️
plugins/omit-commits/src/index.ts 96.87% <ø> (ø) ⬆️
plugins/npm/src/utils.ts 100% <ø> (ø) ⬆️
plugins/npm/src/set-npm-token.ts 100% <ø> (ø) ⬆️
plugins/npm/src/package-config.ts 90.9% <ø> (ø) ⬆️
plugins/upload-assets/src/index.ts 85% <ø> (ø) ⬆️
plugins/s3/src/index.ts 86.04% <ø> (+0.33%) ⬆️
packages/bot-list/src/index.ts 0% <ø> (ø) ⬆️
plugins/omit-release-notes/src/index.ts 96.66% <ø> (ø) ⬆️
plugins/npm/src/index.ts 74.46% <ø> (+0.06%) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729fb79...7a16473. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 727fe80 into master Mar 27, 2020
@hipstersmoothie hipstersmoothie deleted the updated-title-bug branch March 27, 2020 17:54
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.21.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If changed, use latest PR title in release notes and changelog
2 participants